Single glob pattern for filename and path

[fbdb]

Hello,

I'm trying to find a glob pattern which allow me to consider filepath and filenames at the same time.

I was able to find a solution by providing 2 globs pattern, but I was wondering if there was not a way to find with a single glob pattern ?

Here is a small example (I'm trying to consider all files/path which contains the string test, whether it's the filename or it's in one of the directory path name):

$ mkdir -p baz/ footestfoo/
$ touch bartestbar.bar footestfoo/foo.foo baz/test.baz
$ tree
.
├── bartestbar.bar
├── baz
│   └── test.baz
└── footestfoo
    └── foo.foo

2 directories, 3 files

$ rg --files
baz/test.baz
bartestbar.bar
footestfoo/foo.foo

$ rg --glob "*test*" --files
baz/test.baz
bartestbar.bar

$ rg --glob "**/*test*/**" --files
footestfoo/foo.foo

$ rg --glob "**/*test*/**" --glob "*test*" --files
bartestbar.bar
footestfoo/foo.foo
baz/test.baz

So --glob "**/*mystring*/**" --glob "*mystring*" seems to be a solution. However, I was wondering if it was possible to do it in a single pattern ?

Thanks!

(I tried to find any similar question in the gh discussions but couldn't find anything. Moreover, sorry if this is not the place to ask for this, since it's more a "glob" question than a ripgrep's one).

[BurntSushi]

I think you need two globs unfortunately.

The reason why *test* doesn't work is because it doesn't match the basename of footestfoo/foo.foo. That's consistent with GNU grep:

$ grep --include '*test*' -r a ./
./baz/test.baz:a
./bartestbar.bar:a

And the reason why **/*test*/** doesn't work is that a /** suffix implies that the glob should match only the things inside a directory:

ripgrep/crates/ignore/src/gitignore.rs

Lines 509 to 514 in f09b55b

	// If the glob ends with `/**`, then we should only match everything
	// inside a directory, but not the directory itself. Standard globs
	// will match the directory. So we add `/*` to force the issue.
	if glob.actual.ends_with("/**") {
	glob.actual = format!("{}/*", glob.actual);
	}

IMO, this isn't really a great experience. I'm not quite sure how to fix this. It's possible that the /** suffix should be used with gitignores but not with -g/--glob. But I'm hesitant to introduce differences there.

[fbdb]

Thanks for the explanation/context, it makes more sense.

It's possible that the /** suffix should be used with gitignores

Could you elaborate please as to why people would use this suffix with gitignores ? I'm curious

But I'm hesitant to introduce differences there.

I'm not sure that you should. I didn't find many posts online of people requesting the same as I'm asking: I'm either terrible at querying the web, or the only one wanting such a feature. In the latter case, you shouldn't bother.

Thanks !