fix(auth): redirect unauthorized page requests - #628
Open
JustinShetty wants to merge 3 commits into
Open
Conversation
Contributor
Author
|
Happy to hear out other approaches here, this just felt like the minimal change required to improve the typical user's experience |
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 3 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of printing the 401 error's JSON when accessing an unauthorized page (e.g.
/results/21without an active session)This updates the auth handler to distinguish between page navigation (HTML request) and API requests.
/loginThis PR also adds a test to cover the API vs page navigation logic.
Summary by cubic
Redirects unauthorized page navigation to
/logininstead of showing the 401 JSON error, while API requests still get 401 responses.isHtmlPageRequesthelper that detects HTML navigation via GET/HEAD requests whose accept header includestext/html(case-insensitive).Written for commit bbd2f21. Summary will update on new commits.