Enhancements to QThreadExecutor by kristjanvalur · Pull Request #152 · CabbageDevelopment/qasync

kristjanvalur · 2025-08-16T17:02:17Z

This PR enhances the conformity of QThreadExecutor with the Executor protocol.

shutdown() is now thread-safe and there is no race between shutdown() and submit().
shutdown() can be called more than once. This is how the standard Executors work, and is congruent with close() and similar methods.
map() is supported.
cancel_futures argument to shutdown() is supported.

github-actions · 2025-08-16T17:25:43Z

Coverage report

Click to see where and how coverage changed

_{This report was generated by python-coverage-comment-action}

kristjanvalur force-pushed the pool2 branch 2 times, most recently from d79c72e to 9d176df Compare August 16, 2025 17:20

kristjanvalur force-pushed the pool2 branch 2 times, most recently from 601687c to c6807c5 Compare August 19, 2025 14:20

kristjanvalur added 3 commits October 10, 2025 13:58

Protect shutdown with lock. Allow shutdown more than once.

4e0195b

Support the cancel_futures parameter to executor.shutdown()

4e0ef19

add executor.map() functionality

3ba10cd

kristjanvalur force-pushed the pool2 branch from c6807c5 to 3ba10cd Compare October 10, 2025 14:14

kristjanvalur added 2 commits October 10, 2025 15:28

use mocking for cancellation tests to avoid timing issues.

6ec6077

more mocking for test_map

8378c01

kristjanvalur marked this pull request as ready for review October 10, 2025 16:24