feat(widgets): link widget titles to their respective pages#1277
Open
delize wants to merge 1 commit intoCaiJimmy:masterfrom
Open
feat(widgets): link widget titles to their respective pages#1277delize wants to merge 1 commit intoCaiJimmy:masterfrom
delize wants to merge 1 commit intoCaiJimmy:masterfrom
Conversation
- archives.html: Link the "Archives" title to the archives page, consistent with how individual year links already work - taxonomy.html: Change showLink default from false to true so tag-cloud and categories widget titles link to their taxonomy listing pages by default Widget titles are the primary affordance users interact with, so linking them to the full listing page improves navigation. The showLink param can still be set to false to disable this.
Contributor
Author
|
Trying to upload the last minor fixes/features I have for things against v4 so I can clean up my own partials layout. Feel free to decline if desired. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
archives.html: The archives widget title is now linked to the archives page, consistent with how individual year entries already link theretaxonomy.html: ChangedshowLinkdefault fromfalsetotrueso tag-cloud and categories widget titles link to their taxonomy listing pages by defaultMotivation
Widget titles are the primary UI element users see, but currently they're plain text while the content below them links to pages. Linking the titles improves navigation — clicking "Tags" takes you to the full tags listing, clicking "Archives" takes you to the full archives page.
The
showLinkparameter was already implemented intaxonomy.htmlbut defaulted tofalse. This changes the default totruewhile preserving the ability to disable it viashowLink = falsein widget params.Test plan
/tags//categories/showLink = falsein widget params disables the link on taxonomy widgets