Skip to content

add KMP search algorithm (gated by build flag) #1277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 14, 2025
Merged

add KMP search algorithm (gated by build flag) #1277

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b77846d
add SearchByKMP
midzer Feb 23, 2025
7b0afe9
fix linter
midzer Feb 26, 2025
ab9001a
return early if limit hit
midzer Feb 26, 2025
c833603
remove early return limit from KMP search
midzer Feb 26, 2025
dde6088
fix KMP tests
midzer Feb 26, 2025
3361a71
Fix CHOICES_SEARCH_KMP not being set was breaking e2e tests
Xon Mar 14, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix KMP tests
  • Loading branch information
@midzer
midzer committed Feb 26, 2025
commit dde6088902e54c4192dc0972603530e6e16d2a75
4 changes: 2 additions & 2 deletions test/scripts/search/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ describe('search', () => {
describe('kmp', () => {
let searcher: SearchByKMP<SearchableShape>;
beforeEach(() => {
process.env.CHOICES_SEARCH_KMP = undefined;
process.env.CHOICES_SEARCH_KMP = '1';
searcher = new SearchByKMP<SearchableShape>(options);
searcher.index(haystack);
});
Expand All @@ -118,7 +118,7 @@ describe('search', () => {
});
it('label suffix', () => {
const results = searcher.search(`${haystack.length - 1}`);
expect(results.length).eq(0);
expect(results.length).eq(2);
});
});

Expand Down
Loading