Add searchDisabledChoices configuration option to allow disabled choices to appear in search results
#1357
+34
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new configuration option `searchDisabledChoices` that allows disabled choices to appear in search results while remaining non-selectable. Previously, disabled choices were always excluded from search results via the Store's searchableChoices getter. This made it impossible for users to find disabled options even when they wanted to see what options exist but are currently unavailable. Changes: - Add searchDisabledChoices option to Options interface (default: false) - Update Store.searchableChoices getter to respect the new config - Add test coverage for the new functionality - Maintain backward compatibility with default behavior The selection prevention logic in _handleChoiceAction already prevents disabled choices from being selected, so they remain non-selectable even when found in search results. Fixes the limitation where users couldn't search for disabled options to see what choices exist but are currently unavailable.
10 tasks
|
The failing e2e test is from a random browser update and now some icons render differently, that can be ignored |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a new configuration option
searchDisabledChoicesthat allows disabled choices to appear in search results while remaining non-selectable.Previously, disabled choices were always excluded from search results via the Store's searchableChoices getter. This made it impossible for users to find disabled options even when they wanted to see what options exist but are currently unavailable.
Changes:
The selection prevention logic in _handleChoiceAction already prevents disabled choices from being selected, so they remain non-selectable even when found in search results.
Fixes the limitation where users couldn't search for disabled options to see what choices exist but are currently unavailable.
Screenshots
example.mp4
Types of changes
Checklist