Drop PySide2 dependency from the example in Python 3.12+#355
Open
musicinmybrain wants to merge 1 commit intoColinDuquesnoy:masterfrom
Open
Drop PySide2 dependency from the example in Python 3.12+#355musicinmybrain wants to merge 1 commit intoColinDuquesnoy:masterfrom
musicinmybrain wants to merge 1 commit intoColinDuquesnoy:masterfrom
Conversation
PySide2 was never adjusted to work with Python 3.12 and later; all effort went into PySide6 instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PySide2 was never adjusted to work with Python 3.12 and later; all effort went into PySide6 instead.
Unless I misunderstand, since 1c5be2e it seems like the example defaults to
pyqt5anyway. Maybe it would be better to droppyside2unconditionally rather than conditionalizing it on the Python interpreter version? Let me know and I can amend the PR.