-
Notifications
You must be signed in to change notification settings - Fork 25
Adding Multi-Language Support #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
add lang file for tasks.js
I18n localization for tradecard
Replace title and subtitle with json in "The Trade Market" chapter.
In the quests, the amount of silver coins was appearing twice, I fixed it, and now it only appears once.
|
This looks impressive and all. But ive changed the quests quite a lot in recent times. So I probably need you to adapt to the modern changes of the quests. Altough I would hold off on that if I were you as there will probably be more changes to come. Thanks for the insane work though :) I hope you can adapt to the changes once the time comes. |
|
No problem, the script I created updates it very quickly when there are changes. I'll make commits as you continue updating. In the meantime, I'm translating it into Brazilian Portuguese. Thank you very much for the feedback. |
|
Yea there will be constant changes every so often. I recommend you update the PR once the 2.0 release comes around |
|
Hmm, okay, I'll keep an eye on the updates, and in the meantime, I'll work on the Portuguese translation. Thank you very much. |
Pull Request: Adding Multi-Language Support
Description:
This pull request introduces multi-language support to the modpack by extracting hardcoded text strings from quests and moving them to the lang file en_us.json. A pt_br.json file will be added in the future for Portuguese translations. Additionally, "keys" and "values" have been added to the respective files in FTB Quests and KubeJS assets.
Changes Made:
Benefits:
Considerations:
Related Issue:
Open #1
Additional Notes:
Let's work together to provide a more inclusive gaming experience for our players around the world!
Thank you,
DanielSurf