Skip to content

Conversation

@DanielSurf10
Copy link

@DanielSurf10 DanielSurf10 commented Jul 28, 2023

Pull Request: Adding Multi-Language Support

Description:
This pull request introduces multi-language support to the modpack by extracting hardcoded text strings from quests and moving them to the lang file en_us.json. A pt_br.json file will be added in the future for Portuguese translations. Additionally, "keys" and "values" have been added to the respective files in FTB Quests and KubeJS assets.

Changes Made:

  • Extracted hardcoded text strings from quests and moved them to en_us.json.
  • Implemented "keys" and "values" for localization in FTB Quests and KubeJS assets.

Benefits:

  • Improved internationalization and localization capabilities.
  • Easier translation management for future updates.
  • Better user experience for players in different regions.

Considerations:

  • Please ensure that all new text in the language files is properly localized and accurately reflects the original meaning.

Related Issue:
Open #1

Additional Notes:

  • I did everything with a Python script I created; it extracted the values and placed the corresponding key wherever needed.
  • Any other updates that may arise, I will just run the script again, and everything will be up to date.
  • There may be occasional errors; please let me know if anything comes up.

Let's work together to provide a more inclusive gaming experience for our players around the world!

Thank you,
DanielSurf

@DanielSurf10 DanielSurf10 marked this pull request as draft July 28, 2023 19:23
@DanielSurf10 DanielSurf10 marked this pull request as ready for review July 28, 2023 19:24
@DanielSurf10 DanielSurf10 marked this pull request as draft July 28, 2023 19:24
@DanielSurf10 DanielSurf10 changed the title Initial setup multi-language support: Moved hardcoded text to lang file Jul 29, 2023
@DanielSurf10 DanielSurf10 changed the title Multi-language support: Moved hardcoded text to lang file Jul 29, 2023
@DanielSurf10 DanielSurf10 marked this pull request as ready for review September 26, 2023 18:01
@CoolerGangster
Copy link
Owner

This looks impressive and all. But ive changed the quests quite a lot in recent times. So I probably need you to adapt to the modern changes of the quests. Altough I would hold off on that if I were you as there will probably be more changes to come. Thanks for the insane work though :) I hope you can adapt to the changes once the time comes.

@DanielSurf10
Copy link
Author

No problem, the script I created updates it very quickly when there are changes. I'll make commits as you continue updating. In the meantime, I'm translating it into Brazilian Portuguese. Thank you very much for the feedback.

@CoolerGangster
Copy link
Owner

Yea there will be constant changes every so often. I recommend you update the PR once the 2.0 release comes around

@DanielSurf10
Copy link
Author

Hmm, okay, I'll keep an eye on the updates, and in the meantime, I'll work on the Portuguese translation.
Once version 2.0 is released, I'll update the pull request. I'll leave this pull request as a draft until then.

Thank you very much.

@DanielSurf10 DanielSurf10 marked this pull request as draft November 11, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants