copy pgBackRest logs to local machine rather than stream #129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This features copies the pgBackRest logs to a user's local machine. It mimics the behavior we use for the Postgres logs. We have found situation where pgBackRest are large and the previous behavior would time out.
benjaminjb
approved these changes
Jun 23, 2025
There was a problem hiding this comment.
(a) This is (basically) the same logic you introduced in #105 , yeah?
(b) the logic is basically the same between the two commands here -- I wonder if we could extract that logic or even collapse those functions -- but that's a non-necessary improvement, I think
Any issues with testing this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This features copies the pgBackRest logs to a user's local machine. It mimics the behavior we use for the Postgres logs. We have found situation where pgBackRest are large and the previous behavior would time out.