Make jnr-unixsocket an explicit dependency of dd-trace-ot by mcculls · Pull Request #8307 · DataDog/dd-trace-java

mcculls · 2025-01-29T21:08:29Z

What Does This Do

Makes jnr-unixsocket an explicit dependency of dd-trace-ot instead of (partially) shading it.

Motivation

Avoids duplicate class error reported by maven-enforcer-plugin when both dd-trace-ot and java-dogstatsd-client are included in the same Maven project - see #5951

Additional Notes

There is a single leftover class under ddtrot/com/kenai/jffi/PatchInit.class which is our patched Init class used when isolating the embedded library in dd-java-agent. Unfortunately the shadow plugin stubbornly refuses to remove this dangling class despite trying various options. We therefore leave this class in its shaded location - it won't ever be loaded and won't interact with the classes brought in by the jnr-unixsocket dependency.

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the public documentation in case of new configuration flag or behavior

Jira ticket: [PROJ-IDENT]

pr-commenter · 2025-01-29T21:42:29Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mcculls/make-jnr-unixsocket-dependency-of-dd-trace-ot
git_commit_date	1738176129	1738187092
git_commit_sha	`65e472f`	`b8a928f`
release_version	1.46.0-SNAPSHOT~65e472f132	1.46.0-SNAPSHOT~b8a928fbe5

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1738189420	1738189420
ci_job_id	786543441	786543441
ci_pipeline_id	54389934	54389934
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-ojmsshtx-project-304-concurrent-0-zni0rhzu 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-ojmsshtx-project-304-concurrent-0-zni0rhzu 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 52 metrics, 11 unstable metrics.

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.46.0-SNAPSHOT~b8a928fbe5, baseline=1.46.0-SNAPSHOT~65e472f132

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.046 s) : 0, 1045997
Total [baseline] (8.641 s) : 0, 8641277
Agent [candidate] (1.046 s) : 0, 1045855
Total [candidate] (8.642 s) : 0, 8641868
section iast
Agent [baseline] (1.173 s) : 0, 1172816
Total [baseline] (9.266 s) : 0, 9265650
Agent [candidate] (1.176 s) : 0, 1175570
Total [candidate] (9.237 s) : 0, 9237186
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.17 s) : 0, 1170073
Total [baseline] (9.187 s) : 0, 9186509
Agent [candidate] (1.168 s) : 0, 1168458
Total [candidate] (9.19 s) : 0, 9189581
section iast_TELEMETRY_OFF
Agent [baseline] (1.169 s) : 0, 1168915
Total [baseline] (9.233 s) : 0, 9233307
Agent [candidate] (1.165 s) : 0, 1164860
Total [candidate] (9.229 s) : 0, 9228996

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.046 s	-
Agent	iast	1.173 s	126.819 ms (12.1%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.17 s	124.076 ms (11.9%)
Agent	iast_TELEMETRY_OFF	1.169 s	122.918 ms (11.8%)
Total	tracing	8.641 s	-
Total	iast	9.266 s	624.372 ms (7.2%)
Total	iast_HARDCODED_SECRET_DISABLED	9.187 s	545.231 ms (6.3%)
Total	iast_TELEMETRY_OFF	9.233 s	592.03 ms (6.9%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.046 s	-
Agent	iast	1.176 s	129.715 ms (12.4%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.168 s	122.602 ms (11.7%)
Agent	iast_TELEMETRY_OFF	1.165 s	119.004 ms (11.4%)
Total	tracing	8.642 s	-
Total	iast	9.237 s	595.318 ms (6.9%)
Total	iast_HARDCODED_SECRET_DISABLED	9.19 s	547.713 ms (6.3%)
Total	iast_TELEMETRY_OFF	9.229 s	587.128 ms (6.8%)

gantt
    title insecure-bank - break down per module: candidate=1.46.0-SNAPSHOT~b8a928fbe5, baseline=1.46.0-SNAPSHOT~65e472f132

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (720.355 ms) : 0, 720355
BytebuddyAgent [candidate] (719.892 ms) : 0, 719892
GlobalTracer [baseline] (241.584 ms) : 0, 241584
GlobalTracer [candidate] (241.862 ms) : 0, 241862
AppSec [baseline] (55.784 ms) : 0, 55784
AppSec [candidate] (55.868 ms) : 0, 55868
Remote Config [baseline] (726.725 µs) : 0, 727
Remote Config [candidate] (724.29 µs) : 0, 724
Telemetry [baseline] (12.287 ms) : 0, 12287
Telemetry [candidate] (12.219 ms) : 0, 12219
section iast
BytebuddyAgent [baseline] (836.074 ms) : 0, 836074
BytebuddyAgent [candidate] (839.569 ms) : 0, 839569
GlobalTracer [baseline] (232.237 ms) : 0, 232237
GlobalTracer [candidate] (231.239 ms) : 0, 231239
AppSec [baseline] (55.775 ms) : 0, 55775
AppSec [candidate] (55.569 ms) : 0, 55569
Remote Config [baseline] (618.841 µs) : 0, 619
Remote Config [candidate] (624.667 µs) : 0, 625
Telemetry [baseline] (8.71 ms) : 0, 8710
Telemetry [candidate] (8.773 ms) : 0, 8773
IAST [baseline] (24.071 ms) : 0, 24071
IAST [candidate] (24.396 ms) : 0, 24396
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (834.856 ms) : 0, 834856
BytebuddyAgent [candidate] (833.7 ms) : 0, 833700
GlobalTracer [baseline] (230.912 ms) : 0, 230912
GlobalTracer [candidate] (230.595 ms) : 0, 230595
AppSec [baseline] (54.548 ms) : 0, 54548
AppSec [candidate] (53.76 ms) : 0, 53760
Remote Config [baseline] (609.558 µs) : 0, 610
Remote Config [candidate] (621.196 µs) : 0, 621
Telemetry [baseline] (8.73 ms) : 0, 8730
Telemetry [candidate] (8.726 ms) : 0, 8726
IAST [baseline] (25.091 ms) : 0, 25091
IAST [candidate] (25.775 ms) : 0, 25775
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (835.425 ms) : 0, 835425
BytebuddyAgent [candidate] (830.995 ms) : 0, 830995
GlobalTracer [baseline] (230.225 ms) : 0, 230225
GlobalTracer [candidate] (230.223 ms) : 0, 230223
AppSec [baseline] (52.198 ms) : 0, 52198
AppSec [candidate] (53.257 ms) : 0, 53257
Remote Config [baseline] (621.978 µs) : 0, 622
Remote Config [candidate] (618.829 µs) : 0, 619
Telemetry [baseline] (8.576 ms) : 0, 8576
Telemetry [candidate] (8.599 ms) : 0, 8599
IAST [baseline] (26.423 ms) : 0, 26423
IAST [candidate] (25.864 ms) : 0, 25864

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.46.0-SNAPSHOT~b8a928fbe5, baseline=1.46.0-SNAPSHOT~65e472f132

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.042 s) : 0, 1042315
Total [baseline] (10.494 s) : 0, 10494221
Agent [candidate] (1.044 s) : 0, 1044066
Total [candidate] (10.566 s) : 0, 10565845
section appsec
Agent [baseline] (1.18 s) : 0, 1179602
Total [baseline] (10.758 s) : 0, 10758381
Agent [candidate] (1.187 s) : 0, 1187367
Total [candidate] (10.765 s) : 0, 10764527
section iast
Agent [baseline] (1.181 s) : 0, 1181318
Total [baseline] (10.997 s) : 0, 10997051
Agent [candidate] (1.178 s) : 0, 1177870
Total [candidate] (10.933 s) : 0, 10932518
section profiling
Agent [baseline] (1.264 s) : 0, 1264346
Total [baseline] (10.843 s) : 0, 10842653
Agent [candidate] (1.259 s) : 0, 1259383
Total [candidate] (10.871 s) : 0, 10871328

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.042 s	-
Agent	appsec	1.18 s	137.287 ms (13.2%)
Agent	iast	1.181 s	139.003 ms (13.3%)
Agent	profiling	1.264 s	222.031 ms (21.3%)
Total	tracing	10.494 s	-
Total	appsec	10.758 s	264.159 ms (2.5%)
Total	iast	10.997 s	502.829 ms (4.8%)
Total	profiling	10.843 s	348.432 ms (3.3%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.044 s	-
Agent	appsec	1.187 s	143.301 ms (13.7%)
Agent	iast	1.178 s	133.804 ms (12.8%)
Agent	profiling	1.259 s	215.317 ms (20.6%)
Total	tracing	10.566 s	-
Total	appsec	10.765 s	198.682 ms (1.9%)
Total	iast	10.933 s	366.673 ms (3.5%)
Total	profiling	10.871 s	305.483 ms (2.9%)

gantt
    title petclinic - break down per module: candidate=1.46.0-SNAPSHOT~b8a928fbe5, baseline=1.46.0-SNAPSHOT~65e472f132

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (716.739 ms) : 0, 716739
BytebuddyAgent [candidate] (718.266 ms) : 0, 718266
GlobalTracer [baseline] (240.246 ms) : 0, 240246
GlobalTracer [candidate] (240.824 ms) : 0, 240824
AppSec [baseline] (55.546 ms) : 0, 55546
AppSec [candidate] (55.781 ms) : 0, 55781
Remote Config [baseline] (725.927 µs) : 0, 726
Remote Config [candidate] (721.877 µs) : 0, 722
Telemetry [baseline] (13.776 ms) : 0, 13776
Telemetry [candidate] (13.168 ms) : 0, 13168
section appsec
BytebuddyAgent [baseline] (731.647 ms) : 0, 731647
BytebuddyAgent [candidate] (736.742 ms) : 0, 736742
GlobalTracer [baseline] (237.017 ms) : 0, 237017
GlobalTracer [candidate] (238.84 ms) : 0, 238840
AppSec [baseline] (175.561 ms) : 0, 175561
AppSec [candidate] (176.546 ms) : 0, 176546
Remote Config [baseline] (655.986 µs) : 0, 656
Remote Config [candidate] (651.562 µs) : 0, 652
Telemetry [baseline] (8.669 ms) : 0, 8669
Telemetry [candidate] (8.256 ms) : 0, 8256
IAST [baseline] (21.502 ms) : 0, 21502
IAST [candidate] (21.815 ms) : 0, 21815
section iast
BytebuddyAgent [baseline] (843.833 ms) : 0, 843833
BytebuddyAgent [candidate] (840.925 ms) : 0, 840925
GlobalTracer [baseline] (232.681 ms) : 0, 232681
GlobalTracer [candidate] (232.1 ms) : 0, 232100
AppSec [baseline] (53.403 ms) : 0, 53403
AppSec [candidate] (52.545 ms) : 0, 52545
Remote Config [baseline] (630.523 µs) : 0, 631
Remote Config [candidate] (628.631 µs) : 0, 629
Telemetry [baseline] (8.824 ms) : 0, 8824
Telemetry [candidate] (8.771 ms) : 0, 8771
IAST [baseline] (26.495 ms) : 0, 26495
IAST [candidate] (27.298 ms) : 0, 27298
section profiling
BytebuddyAgent [baseline] (708.526 ms) : 0, 708526
BytebuddyAgent [candidate] (706.04 ms) : 0, 706040
GlobalTracer [baseline] (351.867 ms) : 0, 351867
GlobalTracer [candidate] (352.063 ms) : 0, 352063
AppSec [baseline] (55.541 ms) : 0, 55541
AppSec [candidate] (54.156 ms) : 0, 54156
Remote Config [baseline] (708.26 µs) : 0, 708
Remote Config [candidate] (707.023 µs) : 0, 707
Telemetry [baseline] (8.957 ms) : 0, 8957
Telemetry [candidate] (8.946 ms) : 0, 8946
ProfilingAgent [baseline] (96.182 ms) : 0, 96182
ProfilingAgent [candidate] (95.124 ms) : 0, 95124
Profiling [baseline] (96.206 ms) : 0, 96206
Profiling [candidate] (95.149 ms) : 0, 95149

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2025-01-29T21:55:49	2025-01-29T22:02:55
git_branch	master	mcculls/make-jnr-unixsocket-dependency-of-dd-trace-ot
git_commit_date	1738176129	1738187092
git_commit_sha	`65e472f`	`b8a928f`
release_version	1.46.0-SNAPSHOT~65e472f132	1.46.0-SNAPSHOT~b8a928fbe5
start_time	2025-01-29T21:55:35	2025-01-29T22:02:41

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1738188535	1738188535
ci_job_id	786543442	786543442
ci_pipeline_id	54389934	54389934
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-rth72t5k-project-304-concurrent-0-avmb8xkp 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-rth72t5k-project-304-concurrent-0-avmb8xkp 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~b8a928fbe5, baseline=1.46.0-SNAPSHOT~65e472f132
    dateFormat X
    axisFormat %s
section baseline
no_agent (387.029 µs) : 367, 407
.   : milestone, 387,
iast (513.422 µs) : 490, 537
.   : milestone, 513,
iast_FULL (751.927 µs) : 729, 775
.   : milestone, 752,
iast_GLOBAL (561.498 µs) : 539, 584
.   : milestone, 561,
iast_HARDCODED_SECRET_DISABLED (510.424 µs) : 488, 533
.   : milestone, 510,
iast_INACTIVE (460.034 µs) : 439, 481
.   : milestone, 460,
iast_TELEMETRY_OFF (496.884 µs) : 474, 520
.   : milestone, 497,
tracing (464.7 µs) : 443, 487
.   : milestone, 465,
section candidate
no_agent (383.855 µs) : 364, 403
.   : milestone, 384,
iast (516.546 µs) : 493, 540
.   : milestone, 517,
iast_FULL (746.343 µs) : 723, 769
.   : milestone, 746,
iast_GLOBAL (561.915 µs) : 540, 584
.   : milestone, 562,
iast_HARDCODED_SECRET_DISABLED (516.781 µs) : 494, 540
.   : milestone, 517,
iast_INACTIVE (463.816 µs) : 441, 487
.   : milestone, 464,
iast_TELEMETRY_OFF (500.817 µs) : 478, 524
.   : milestone, 501,
tracing (458.266 µs) : 437, 479
.   : milestone, 458,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	387.029 µs [366.874 µs, 407.183 µs]	-
iast	513.422 µs [489.965 µs, 536.879 µs]	126.393 µs (32.7%)
iast_FULL	751.927 µs [728.952 µs, 774.902 µs]	364.898 µs (94.3%)
iast_GLOBAL	561.498 µs [539.473 µs, 583.524 µs]	174.47 µs (45.1%)
iast_HARDCODED_SECRET_DISABLED	510.424 µs [487.531 µs, 533.317 µs]	123.395 µs (31.9%)
iast_INACTIVE	460.034 µs [438.973 µs, 481.094 µs]	73.005 µs (18.9%)
iast_TELEMETRY_OFF	496.884 µs [473.871 µs, 519.897 µs]	109.855 µs (28.4%)
tracing	464.7 µs [442.704 µs, 486.696 µs]	77.671 µs (20.1%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	383.855 µs [364.466 µs, 403.245 µs]	-
iast	516.546 µs [492.958 µs, 540.135 µs]	132.691 µs (34.6%)
iast_FULL	746.343 µs [723.457 µs, 769.229 µs]	362.487 µs (94.4%)
iast_GLOBAL	561.915 µs [539.807 µs, 584.022 µs]	178.059 µs (46.4%)
iast_HARDCODED_SECRET_DISABLED	516.781 µs [493.509 µs, 540.054 µs]	132.926 µs (34.6%)
iast_INACTIVE	463.816 µs [441.046 µs, 486.586 µs]	79.961 µs (20.8%)
iast_TELEMETRY_OFF	500.817 µs [477.992 µs, 523.642 µs]	116.962 µs (30.5%)
tracing	458.266 µs [437.234 µs, 479.299 µs]	74.411 µs (19.4%)

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.46.0-SNAPSHOT~b8a928fbe5, baseline=1.46.0-SNAPSHOT~65e472f132
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.357 ms) : 1337, 1377
.   : milestone, 1357,
appsec (1.763 ms) : 1740, 1786
.   : milestone, 1763,
appsec_no_iast (1.754 ms) : 1731, 1777
.   : milestone, 1754,
iast (1.506 ms) : 1482, 1530
.   : milestone, 1506,
profiling (1.551 ms) : 1526, 1576
.   : milestone, 1551,
tracing (1.494 ms) : 1470, 1518
.   : milestone, 1494,
section candidate
no_agent (1.339 ms) : 1318, 1359
.   : milestone, 1339,
appsec (1.777 ms) : 1753, 1801
.   : milestone, 1777,
appsec_no_iast (1.78 ms) : 1755, 1805
.   : milestone, 1780,
iast (1.486 ms) : 1463, 1510
.   : milestone, 1486,
profiling (1.551 ms) : 1525, 1576
.   : milestone, 1551,
tracing (1.488 ms) : 1463, 1514
.   : milestone, 1488,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.357 ms [1.337 ms, 1.377 ms]	-
appsec	1.763 ms [1.74 ms, 1.786 ms]	405.665 µs (29.9%)
appsec_no_iast	1.754 ms [1.731 ms, 1.777 ms]	396.752 µs (29.2%)
iast	1.506 ms [1.482 ms, 1.53 ms]	148.669 µs (11.0%)
profiling	1.551 ms [1.526 ms, 1.576 ms]	193.407 µs (14.2%)
tracing	1.494 ms [1.47 ms, 1.518 ms]	136.736 µs (10.1%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.339 ms [1.318 ms, 1.359 ms]	-
appsec	1.777 ms [1.753 ms, 1.801 ms]	437.731 µs (32.7%)
appsec_no_iast	1.78 ms [1.755 ms, 1.805 ms]	441.368 µs (33.0%)
iast	1.486 ms [1.463 ms, 1.51 ms]	147.353 µs (11.0%)
profiling	1.551 ms [1.525 ms, 1.576 ms]	211.695 µs (15.8%)
tracing	1.488 ms [1.463 ms, 1.514 ms]	149.623 µs (11.2%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mcculls/make-jnr-unixsocket-dependency-of-dd-trace-ot
git_commit_date	1738176129	1738187092
git_commit_sha	`65e472f`	`b8a928f`
release_version	1.46.0-SNAPSHOT~65e472f132	1.46.0-SNAPSHOT~b8a928fbe5

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1738189093	1738189093
ci_job_id	786543443	786543443
ci_pipeline_id	54389934	54389934
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-ojmsshtx-project-304-concurrent-1-nh6hqgz2 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-ojmsshtx-project-304-concurrent-1-nh6hqgz2 6.8.0-1021-aws #23~22.04.1-Ubuntu SMP Tue Dec 10 16:50:46 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~b8a928fbe5, baseline=1.46.0-SNAPSHOT~65e472f132
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.533 s) : 15533000, 15533000
.   : milestone, 15533000,
appsec (15.155 s) : 15155000, 15155000
.   : milestone, 15155000,
iast (18.84 s) : 18840000, 18840000
.   : milestone, 18840000,
iast_GLOBAL (17.773 s) : 17773000, 17773000
.   : milestone, 17773000,
profiling (15.081 s) : 15081000, 15081000
.   : milestone, 15081000,
tracing (14.987 s) : 14987000, 14987000
.   : milestone, 14987000,
section candidate
no_agent (15.644 s) : 15644000, 15644000
.   : milestone, 15644000,
appsec (15.185 s) : 15185000, 15185000
.   : milestone, 15185000,
iast (18.701 s) : 18701000, 18701000
.   : milestone, 18701000,
iast_GLOBAL (17.97 s) : 17970000, 17970000
.   : milestone, 17970000,
profiling (14.911 s) : 14911000, 14911000
.   : milestone, 14911000,
tracing (15.12 s) : 15120000, 15120000
.   : milestone, 15120000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.533 s [15.533 s, 15.533 s]	-
appsec	15.155 s [15.155 s, 15.155 s]	-378.0 ms (-2.4%)
iast	18.84 s [18.84 s, 18.84 s]	3.307 s (21.3%)
iast_GLOBAL	17.773 s [17.773 s, 17.773 s]	2.24 s (14.4%)
profiling	15.081 s [15.081 s, 15.081 s]	-452.0 ms (-2.9%)
tracing	14.987 s [14.987 s, 14.987 s]	-546.0 ms (-3.5%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.644 s [15.644 s, 15.644 s]	-
appsec	15.185 s [15.185 s, 15.185 s]	-459.0 ms (-2.9%)
iast	18.701 s [18.701 s, 18.701 s]	3.057 s (19.5%)
iast_GLOBAL	17.97 s [17.97 s, 17.97 s]	2.326 s (14.9%)
profiling	14.911 s [14.911 s, 14.911 s]	-733.0 ms (-4.7%)
tracing	15.12 s [15.12 s, 15.12 s]	-524.0 ms (-3.3%)

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.46.0-SNAPSHOT~b8a928fbe5, baseline=1.46.0-SNAPSHOT~65e472f132
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.47 ms) : 1458, 1481
.   : milestone, 1470,
appsec (2.348 ms) : 2305, 2391
.   : milestone, 2348,
iast (2.098 ms) : 2043, 2153
.   : milestone, 2098,
iast_GLOBAL (2.153 ms) : 2098, 2208
.   : milestone, 2153,
profiling (2.451 ms) : 2262, 2639
.   : milestone, 2451,
tracing (1.934 ms) : 1891, 1976
.   : milestone, 1934,
section candidate
no_agent (1.465 ms) : 1454, 1477
.   : milestone, 1465,
appsec (2.346 ms) : 2302, 2389
.   : milestone, 2346,
iast (2.1 ms) : 2045, 2154
.   : milestone, 2100,
iast_GLOBAL (2.15 ms) : 2096, 2205
.   : milestone, 2150,
profiling (1.966 ms) : 1923, 2010
.   : milestone, 1966,
tracing (1.951 ms) : 1908, 1993
.   : milestone, 1951,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.47 ms [1.458 ms, 1.481 ms]	-
appsec	2.348 ms [2.305 ms, 2.391 ms]	878.491 µs (59.8%)
iast	2.098 ms [2.043 ms, 2.153 ms]	627.938 µs (42.7%)
iast_GLOBAL	2.153 ms [2.098 ms, 2.208 ms]	683.001 µs (46.5%)
profiling	2.451 ms [2.262 ms, 2.639 ms]	980.567 µs (66.7%)
tracing	1.934 ms [1.891 ms, 1.976 ms]	463.586 µs (31.5%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.465 ms [1.454 ms, 1.477 ms]	-
appsec	2.346 ms [2.302 ms, 2.389 ms]	880.194 µs (60.1%)
iast	2.1 ms [2.045 ms, 2.154 ms]	634.529 µs (43.3%)
iast_GLOBAL	2.15 ms [2.096 ms, 2.205 ms]	685.137 µs (46.8%)
profiling	1.966 ms [1.923 ms, 2.01 ms]	500.822 µs (34.2%)
tracing	1.951 ms [1.908 ms, 1.993 ms]	485.383 µs (33.1%)

github-actions · 2025-01-29T22:14:21Z

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

PerfectSlayer

Sounds good

| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-datastore](https://github.com/googleapis/java-datastore) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.25.4` -> `2.26.0` | | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.45.2` -> `1.46.0` | | [com.datadoghq:dd-trace-ot](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.45.2` -> `1.46.0` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.9` -> `2.30.10` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.9` -> `2.30.10` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.9` -> `2.30.10` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.9` -> `2.30.10` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.9` -> `2.30.10` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.30.9` -> `2.30.10` | --- ### Release Notes <details> <summary>googleapis/java-datastore (com.google.cloud:google-cloud-datastore)</summary> ### [`v2.26.0`](https://github.com/googleapis/java-datastore/blob/HEAD/CHANGELOG.md#2260-2025-01-29) ##### Features - Add firestoreInDatastoreMode for datastore emulator ([#1698](googleapis/java-datastore#1698)) ([50f106d](googleapis/java-datastore@50f106d)) ##### Dependencies - Update dependency com.google.cloud:sdk-platform-java-config to v3.42.0 ([#1725](googleapis/java-datastore#1725)) ([1cbaf22](googleapis/java-datastore@1cbaf22)) </details> <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.46.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.46.0): 1.46.0 ##### Breaking Changes > \[!WARNING] > jnr-unixsocket is now an external dependency of dd-trace-ot and must be included when deploying dd-trace-ot. > \[!NOTE] > The API `TracerScope.setAsync(boolean)`, used to manually control asynchronous span propagation, does no more apply to the scope instance but to the active span scope. ##### Components ##### Application Security Management (IAST) - 🐛 Fix String.replace instrumentation for IAST ([#8281](DataDog/dd-trace-java#8281) - [@Mariovido](https://github.com/Mariovido)) - ✨ Apply the standard nomenclature to the stacktrace configs ([#8244](DataDog/dd-trace-java#8244) - [@jandro996](https://github.com/jandro996)) - 🐛 Exclude false positive weak randomness ([#8232](DataDog/dd-trace-java#8232) - [@jandro996](https://github.com/jandro996)) - ✨ Propagation of translateEscapes of String class ([#8186](DataDog/dd-trace-java#8186) - [@sezen-datadog](https://github.com/sezen-datadog)) - ✨ Add security control metrics ([#8175](DataDog/dd-trace-java#8175) - [@jandro996](https://github.com/jandro996)) - ✨ Increase IAST propagation to StringBuffer setLength ([#8128](DataDog/dd-trace-java#8128) - [@Mariovido](https://github.com/Mariovido)) - ✨ Add IAST taint tracking for DB values ([#8072](DataDog/dd-trace-java#8072) - [@Mariovido](https://github.com/Mariovido)) ##### Application Security Management (WAF) - 🐛 Prevents a NPE when there is no subscriber for user events ([#8258](DataDog/dd-trace-java#8258) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Apply the standard nomenclature to the stacktrace configs ([#8244](DataDog/dd-trace-java#8244) - [@jandro996](https://github.com/jandro996)) - 🐛 Ensure cached subscriptions are cleared on reconfiguration via RC ([#8229](DataDog/dd-trace-java#8229) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Add support for session tracking in Vertx ([#8167](DataDog/dd-trace-java#8167) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) - ✨ Create span tag: \_dd.appsec.rasp.timeout ([#8269](DataDog/dd-trace-java#8269) - [@Mariovido](https://github.com/Mariovido)) ##### Build & Tooling - 🐛 Ensure shaded helpers have unique names when injected into class-loaders ([#8192](DataDog/dd-trace-java#8192) - [@mcculls](https://github.com/mcculls)) ##### Configuration at Runtime - 🐛 Remove filtering of `DD_SERVICE` and `DD_ENV` from the tracer ([#8176](DataDog/dd-trace-java#8176) - [@mhlidd](https://github.com/mhlidd)) ##### Continuous Integration Visibility - 🧹 Generalize TestRetryPolicy to TestExecutionPolicy ([#8302](DataDog/dd-trace-java#8302) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🧹 Parallelize CI Visibility settings requests ([#8299](DataDog/dd-trace-java#8299) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🧹 Generalize test retry logic ([#8289](DataDog/dd-trace-java#8289) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🧹 Generalize tests skipping logic ([#8288](DataDog/dd-trace-java#8288) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🧹 Remove skip and shouldBeSkipped methods from TestEventsHandler in favor of isSkippable ([#8286](DataDog/dd-trace-java#8286) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨⚡ Optimize Git repository information computation ([#8270](DataDog/dd-trace-java#8270) - [@dougqh](https://github.com/dougqh)) - ✨ Always request known tests from the backend ([#8268](DataDog/dd-trace-java#8268) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Fix NPE when trying to get retry analyzer in Test NG ([#8253](DataDog/dd-trace-java#8253) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Set test framework and test framework version tags atomically ([#8252](DataDog/dd-trace-java#8252) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Add debug logging to Android Gradle module layout logic ([#8251](DataDog/dd-trace-java#8251) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Fix source and destination folders computation for Android Gradle projects ([#8190](DataDog/dd-trace-java#8190) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - ✨ Add basic Scala Weaver sbt support ([#8189](DataDog/dd-trace-java#8189) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Implement impacted tests detection ([#8188](DataDog/dd-trace-java#8188) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) ##### Data Streams Monitoring - ✨ Change hash computation for protobuf to better represent impacting changes + save proto number in schema ([#8201](DataDog/dd-trace-java#8201) - [@vandonr](https://github.com/vandonr)) ##### Database Monitoring - Add peer service tag in dbm sql commenter ([#7913](DataDog/dd-trace-java#7913) - [@jordan-wong](https://github.com/jordan-wong)) ##### Dynamic Instrumentation - ✨ Add support for SymDB to scan directories ([#8306](DataDog/dd-trace-java#8306) - [@jpbempel](https://github.com/jpbempel)) - ✨ Add SymDB report for any jar scanning failures ([#8300](DataDog/dd-trace-java#8300) - [@jpbempel](https://github.com/jpbempel)) - ✨ Use two budgets depending on type ([#8283](DataDog/dd-trace-java#8283) - [@evanchooly](https://github.com/evanchooly)) - ✨ Institute a 10 snapshot per probe per trace budget ([#8277](DataDog/dd-trace-java#8277) - [@evanchooly](https://github.com/evanchooly)) - 🐛 Avoid double snapshots for Exception Replay ([#8273](DataDog/dd-trace-java#8273) - [@jpbempel](https://github.com/jpbempel)) - ✨ Simplify code origins. Separate out snapshot generation. ([#8263](DataDog/dd-trace-java#8263) - [@evanchooly](https://github.com/evanchooly)) - ✨ Add Exception probe custom instrumentation ([#8230](DataDog/dd-trace-java#8230) - [@jpbempel](https://github.com/jpbempel)) - ✨ Enhance log probes to honor debug session tags ([#8215](DataDog/dd-trace-java#8215) - [@evanchooly](https://github.com/evanchooly)) - 🐛 Don't redact env tokens from debugger probe snapshots ([#8211](DataDog/dd-trace-java#8211) - [@watson](https://github.com/watson)) - ✨⚡ Move Trace/SpanId capture at commit time ([#8184](DataDog/dd-trace-java#8184) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Capture values at entry for method probe ([#8169](DataDog/dd-trace-java#8169) - [@jpbempel](https://github.com/jpbempel)) ##### JMX fetch - 🐛 Mute JMXFetch Shutdown in progress error ([#8068](DataDog/dd-trace-java#8068) - [@ygree](https://github.com/ygree)) ##### OpenTracing - ⚠️🧹 Make jnr-unixsocket an explicit dependency of dd-trace-ot ([#8307](DataDog/dd-trace-java#8307) - [@mcculls](https://github.com/mcculls)) ##### Profiling - 🐛 Avoid unsupported API call for creating folders on windows ([#8304](DataDog/dd-trace-java#8304) - [@jbachorik](https://github.com/jbachorik)) - ✨ Tag profiles for serverless ([#8279](DataDog/dd-trace-java#8279) - [@jbachorik](https://github.com/jbachorik)) - ✨ add queue type and length to queue events ([#8242](DataDog/dd-trace-java#8242) - [@richardstartin](https://github.com/richardstartin)) - 🐛 TempLocationManager Fixes and Improvements ([#8191](DataDog/dd-trace-java#8191) - [@jbachorik](https://github.com/jbachorik)) - ✨ Bump ddprof to 1.18.0 ([#8173](DataDog/dd-trace-java#8173) - [@jbachorik](https://github.com/jbachorik)) - ✨ Report profiler initialization and configuration errors to telemetry ([#8171](DataDog/dd-trace-java#8171) - [@jbachorik](https://github.com/jbachorik)) ##### Telemetry - ✨ Add pending traces report in tracer flares ([#8053](DataDog/dd-trace-java#8053) - [@mhlidd](https://github.com/mhlidd)) ##### Testing - ✨ Test http server requests in parallel ([#8222](DataDog/dd-trace-java#8222) - [@amarziali](https://github.com/amarziali)) ##### Trace context propagation - ✨ Add non default propagator registration ([#8310](DataDog/dd-trace-java#8310) - [@PerfectSlayer](https://github.com/PerfectSlayer)) ##### Tracer core - ✨ Probe for existence of IBMSASL or ACCP security providers ([#8276](DataDog/dd-trace-java#8276) - [@mcculls](https://github.com/mcculls)) - ✨⚡ Overhead improvement to agent feedback based sampling ([#8265](DataDog/dd-trace-java#8265) - [@dougqh](https://github.com/dougqh)) - 🧹 Move async propagation API from scope to tracer ([#8231](DataDog/dd-trace-java#8231) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - ✨ Introduce context propagation API ([#8161](DataDog/dd-trace-java#8161) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - ✨🧪 Use env-entry to add tags per webapp deployment ([#8138](DataDog/dd-trace-java#8138) - [@amarziali](https://github.com/amarziali)) - ✨ Introduce context helpers API ([#8134](DataDog/dd-trace-java#8134) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - ✨ Support IPv6 values for `DD_AGENT_HOST` and `DD_TRACE_AGENT_URL` ([#7984](DataDog/dd-trace-java#7984) - [@mhlidd](https://github.com/mhlidd)) ##### Instrumentations ##### Apache HttpComponents - 🐛 Properly finish spans and support latest apache httpclient5 ([#8272](DataDog/dd-trace-java#8272) - [@amarziali](https://github.com/amarziali)) ##### AWS Lambda instrumentation - 🐛 Properly capture lambda payloads for all handler types. ([#8264](DataDog/dd-trace-java#8264) - [@purple4reina](https://github.com/purple4reina)) ##### AWS S3 instrumentation - 💡 Create S3 instrumentation + add span pointers ([#8075](DataDog/dd-trace-java#8075) - [@nhulston](https://github.com/nhulston)) ##### AWS SDK instrumentation - 🐛 Revert "Add avoid double instrumenting lambda non-streaming handlers." ([#8247](DataDog/dd-trace-java#8247) - [@nhulston](https://github.com/nhulston)) ##### Cassandra - ✨ Allow extracting keyspace from statement result ([#8239](DataDog/dd-trace-java#8239) - [@amarziali](https://github.com/amarziali)) ##### Core Java language instrumentation - ✨ Propagation of translateEscapes of String class ([#8186](DataDog/dd-trace-java#8186) - [@sezen-datadog](https://github.com/sezen-datadog)) ##### Eclipse Vert.x instrumentation - 🐛 Fix vertx worker propagation and error handling ([#8237](DataDog/dd-trace-java#8237) - [@amarziali](https://github.com/amarziali)) - ✨ Support vertx 5 ([#8220](DataDog/dd-trace-java#8220) - [@amarziali](https://github.com/amarziali)) - ✨ Add support for session tracking in Vertx ([#8167](DataDog/dd-trace-java#8167) - [@manuel-alvarez-alvarez](https://github.com/manuel-alvarez-alvarez)) ##### Kafka instrumentation - 🐛 Prevent possible NPE calculating Kafka record header size ([#8292](DataDog/dd-trace-java#8292) - [@ygree](https://github.com/ygree)) ##### Mule instrumentation - 🐛 Fix crash using Mule with JPMS ([#8187](DataDog/dd-trace-java#8187) - [@amarziali](https://github.com/amarziali)) ##### Protocol Buffer instrumentation - ✨ Change hash computation for protobuf to better represent impacting changes + save proto number in schema ([#8201](DataDog/dd-trace-java#8201) - [@vandonr](https://github.com/vandonr)) ##### Spring instrumentation - 🐛 Preserve getQualifier from spring scheduling runnables ([#8293](DataDog/dd-trace-java#8293) - [@amarziali](https://github.com/amarziali)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: bb09d47e4eed77a003f630273b4d0a84003eb899

mcculls added tag: breaking change Breaking changes type: refactoring comp: opentracing OpenTracing labels Jan 29, 2025

mcculls requested a review from a team as a code owner January 29, 2025 21:08

mcculls requested a review from amarziali January 29, 2025 21:08

Make jnr-unixsocket an explicit dependency of dd-trace-ot

b8a928f

mcculls force-pushed the mcculls/make-jnr-unixsocket-dependency-of-dd-trace-ot branch from f992a76 to b8a928f Compare January 29, 2025 21:45

mcculls added type: refactoring and removed type: refactoring labels Jan 29, 2025

mcculls enabled auto-merge (squash) January 29, 2025 22:15

mcculls requested a review from dougqh January 29, 2025 22:27

PerfectSlayer approved these changes Jan 30, 2025

View reviewed changes

mcculls merged commit 886dd6c into master Jan 30, 2025

mcculls deleted the mcculls/make-jnr-unixsocket-dependency-of-dd-trace-ot branch January 30, 2025 08:15

github-actions Bot added this to the 1.46.0 milestone Jan 30, 2025

Navigation Menu

Uh oh!

Make jnr-unixsocket an explicit dependency of dd-trace-ot - #8307

Make jnr-unixsocket an explicit dependency of dd-trace-ot#8307
mcculls merged 1 commit into
masterfrom
mcculls/make-jnr-unixsocket-dependency-of-dd-trace-ot

mcculls commented Jan 29, 2025

pr-commenter Bot commented Jan 29, 2025 •

edited

Loading

github-actions Bot commented Jan 29, 2025

PerfectSlayer left a comment

Labels

2 participants

Uh oh!

Conversation

mcculls commented Jan 29, 2025

What Does This Do

Motivation

Additional Notes

Contributor Checklist

pr-commenter Bot commented Jan 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

github-actions Bot commented Jan 29, 2025

PerfectSlayer left a comment

Choose a reason for hiding this comment

Labels

2 participants

pr-commenter Bot commented Jan 29, 2025 •

edited

Loading