Skip to content

Don't paint collapsed table borders across spanning cells - #793

Open
cnqso wants to merge 1 commit into
DioxusLabs:mainfrom
cnqso:pr/collapsed-border-spans
Open

Don't paint collapsed table borders across spanning cells#793
cnqso wants to merge 1 commit into
DioxusLabs:mainfrom
cnqso:pr/collapsed-border-spans

Conversation

@cnqso

@cnqso cnqso commented Aug 25, 2026 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown

Internal gutters were drawn full-width and full-height, ignoring colspan and rowspan. Amended to skip the tracks covered in spanning cells.

WPT results

No changes in test results compared to main.

Generated by the WPT workflow.
@cnqso
Don't paint collapsed table borders across spanning cells
6cce7d8 
Internal gutters were drawn as full-width/full-height rectangles, so a
cell with colspan or rowspan had a border painted straight through it.
Skip the tracks covered by a spanning cell.
@cnqso

cnqso commented Aug 25, 2026

Copy link
Copy Markdown
Author

Before and after demonstration for clarity :)

For html:

<!doctype html>
<html><head><meta charset="utf-8"><style>
  body { font: 15px/1.4 system-ui, sans-serif; margin: 24px; background: #fff; color: #111; }
  h2 { font-size: 13px; text-transform: uppercase; letter-spacing: .06em;
       color: #666; margin: 22px 0 8px; font-weight: 600; }
  table { border-collapse: collapse; width: 420px; }
  td { border: 1px solid #333; padding: 8px 10px; }
  .title { font-weight: 600; }
</style></head>
<body>
  <h2>colspan</h2>
  <table>
    <tr><td class="title" colspan="2">British Sales of Opium to China</td></tr>
    <tr><td>Year</td><td>Number of chests</td></tr>
    <tr><td>1729</td><td>200</td></tr>
    <tr><td>1832</td><td>23,570</td></tr>
  </table>

  <h2>rowspan</h2>
  <table>
    <tr><td rowspan="3" class="title">Qing</td><td>1729</td><td>200</td></tr>
    <tr><td>1790</td><td>4,054</td></tr>
    <tr><td>1832</td><td>23,570</td></tr>
  </table>
</body></html>

Before:
before

After:
after
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant

@cnqso