feat: add configurable middlewares for domains #3374
+7,267
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR about?
This PR adds the capability to add custom middlewares to domain configurations.
This allows users to use arbitrary middlewares in their applications e.g. for advanced authentication mechanisms, custom error handling, ...
The implementation allows entering arbitrary middleware names and it is the users responsibility to ensure these exist. See screenshots for a working example.
Checklist
Before submitting this PR, please make sure that:
canarybranch.Issues related (if applicable)
closes #274
works towards resolution/improvement of #825, #2521
Screenshots
Additional notes
At the moment the user has to define the middleware in the Traefik config file or via labels. A nice future improvement would be a form based configuration of middlewares in the UI.