TakePOS Cash Control report: Fix incorrect float approximation and string/float mix on test #36003
+3
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eldy
reviewed
Oct 30, 2025
htdocs/compta/cashcontrol/report.php
Outdated
| print '<div class="inline-block amount width100">'.price($cash).'</div>'; | ||
| } | ||
| if (!$summaryonly && $object->status == $object::STATUS_VALIDATED && $newcash != $object->cash) { | ||
| if (!$summaryonly && $object->status == $object::STATUS_VALIDATED && price($newcash) != price($object->cash)) { |
There was a problem hiding this comment.
price is a text formating function.
For comparison of amount, it should be smantically better to do
prcie2num( ) != price2num()
Can you check this way ?
Of you can also try
if (float) $newcash != (float) $object->cash
There was a problem hiding this comment.
It works with price2num but not with the (float) cast.
By the way, I have an instinctive fear of using floats for equality test (moreover, transtyped floats) so I tend to prefer using price2num that returns strings. If the solution is acceptable to you, I would add another commit replacing price() with price2num() in my changes.
eldy
added
the
Discussion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test used in the Cash Control report of TakePOS was using float approximation between equality tests, leading to incoherent information shown in cash report. On the first test, string/float mix was also used.
This commit changes the test to use the displayed value for testing, to show the "Declared" red label only if a difference is actually visible to the user.