bgpd: Enable enforce-first-as by default#14661
Merged
riw777 merged 2 commits intoOct 31, 2023
Merged
Conversation
ton31337
force-pushed
the
feature/enable_enforce_first_as_by_default
branch
from
19a2bef to
74682f9
Compare
|
I think we should definitely update docs and release notes whenever this gets into an official release. Specifically, the place I see this possibly causing an issue is for IXP/Route-server client deployments. In that use case it is common and expected to have an eBGP peer (the RS) that doesn't prepend its own ASN to the AS-Path. So this change to defaults could result in routes from the RS being dropped after an FRR upgrade. |
Member
Author
|
That's why it's a draft, and I wanted to see what's failing first. |
Contributor
|
Closes #14617 |
For the same reason as we disable debug logs for CI everywhere. Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
ton31337
force-pushed
the
feature/enable_enforce_first_as_by_default
branch
from
74682f9 to
ae9b070
Compare
ton31337
force-pushed
the
feature/enable_enforce_first_as_by_default
branch
from
ae9b070 to
b41e4c1
Compare
It's been for a while disabled by default, but this seems reasonable to flip it. We had `bgp enforce-first-as` as a global BGP knob to enable/disable this behavior globally, later we introduced `enforce-first-as` per neighbor, with disabled by default. Now let's enable this by default by bringing a global `bgp enforce-first-as` command back. Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
ton31337
force-pushed
the
feature/enable_enforce_first_as_by_default
branch
from
b41e4c1 to
3224629
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's been for a while disabled by default, but this seems reasonable to flip it.
We had
bgp enforce-first-asas a global BGP knob to enable/disable this behavior globally, later we introducedenforce-first-asper neighbor, with disabled by default. Now let's enable this by default.