-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add Hide channels based on text #7948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
Add Hide channels based on text #7948
Conversation
|
This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please address all the lint warnings
Head branch was pushed to by a user without write access
static/locales/en-US.yaml
Outdated
| Hide Channels: Enter a channel ID to hide all videos, playlists and the channel itself from appearing in search, trending, most popular and recommended. | ||
| The channel ID entered must be a complete match and is case sensitive. | ||
| Hide Subscriptions Live: 'This setting is overridden by the app-wide "{appWideSetting}" setting, in the "{subsection}" section of the "{settingsSection}"' | ||
| Hide Channels Containing Text: 'Hides channels & all matching videos from channels whose name contains the above text' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adds a toggle button to hide all channels, playlists and videos from channels that are matching/contain any strings from the existing tags of "Hide videos and playlists containing text"
Your PR description is very clear but when i read this its very confusing. Also dont use &
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
im not sure if a toggle is the right way to go here. It looks very out of place and enabling it doesnt make it clear to me what it does
Head branch was pushed to by a user without write access
|
@ozrendev could you update the PR body to reflect the latest changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Head branch was pushed to by a user without write access
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Channel is hidden everywhere expect community tab
VirtualBoxVM_OtUE0jiHZp.mp4
Head branch was pushed to by a user without write access
|
Video gets removed but the post is still there. I meant to not show the post at all |
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
Head branch was pushed to by a user without write access
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
Head branch was pushed to by a user without write access
Pull Request is not mergeable
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Head branch was pushed to by a user without write access
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |

Pull Request Type
Related issue
closes #7426
Description
Updates the "Hide videos and playlists containing text" filter to also include/hide channels.
Testing
Check that the filter is working for: