Skip to content

Conversation

@ozrendev
Copy link
Contributor

@ozrendev ozrendev commented Aug 27, 2025

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Related issue

closes #7426

Description

Updates the "Hide videos and playlists containing text" filter to also include/hide channels.

Testing

Check that the filter is working for:

  • Recommended videos
  • Autoplay videos
  • Subscription home page
  • Search results
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) August 27, 2025 11:15
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Aug 27, 2025
@github-actions
Copy link
Contributor

This PR is stale because it has been open 14 days with no activity. Remove stale label or comment or this will be closed in 14 days.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address all the lint warnings

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc added PR: changes requested and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Sep 20, 2025
auto-merge was automatically disabled September 22, 2025 08:33

Head branch was pushed to by a user without write access

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) September 22, 2025 08:34
Hide Channels: Enter a channel ID to hide all videos, playlists and the channel itself from appearing in search, trending, most popular and recommended.
The channel ID entered must be a complete match and is case sensitive.
Hide Subscriptions Live: 'This setting is overridden by the app-wide "{appWideSetting}" setting, in the "{subsection}" section of the "{settingsSection}"'
Hide Channels Containing Text: 'Hides channels & all matching videos from channels whose name contains the above text'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adds a toggle button to hide all channels, playlists and videos from channels that are matching/contain any strings from the existing tags of "Hide videos and playlists containing text"

Your PR description is very clear but when i read this its very confusing. Also dont use &

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im not sure if a toggle is the right way to go here. It looks very out of place and enabling it doesnt make it clear to me what it does

auto-merge was automatically disabled September 24, 2025 18:54

Head branch was pushed to by a user without write access

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) September 24, 2025 18:55
@efb4f5ff-1298-471a-8973-3d47447115dc

@ozrendev could you update the PR body to reflect the latest changes

Copy link
Member

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the tooltip message and title of the feature to include channels

VirtualBoxVM_aDA64RtuRJ
auto-merge was automatically disabled October 6, 2025 09:11

Head branch was pushed to by a user without write access

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) October 6, 2025 09:11
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Channel is hidden everywhere expect community tab

VirtualBoxVM_OtUE0jiHZp.mp4
auto-merge was automatically disabled October 6, 2025 17:54

Head branch was pushed to by a user without write access

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) October 6, 2025 17:54
@efb4f5ff-1298-471a-8973-3d47447115dc

Video gets removed but the post is still there. I meant to not show the post at all

auto-merge was automatically disabled October 6, 2025 18:25

Head branch was pushed to by a user without write access

auto-merge was automatically disabled October 30, 2025 19:58

Head branch was pushed to by a user without write access

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) October 30, 2025 19:58
auto-merge was automatically disabled October 30, 2025 20:28

Head branch was pushed to by a user without write access

@github-actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) October 30, 2025 20:28
auto-merge was automatically disabled October 30, 2025 20:31

Head branch was pushed to by a user without write access

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) October 30, 2025 20:31
auto-merge was automatically disabled October 30, 2025 20:35

Pull Request is not mergeable

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) October 30, 2025 20:35
@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc added PR: waiting for review For PRs that are complete, tested, and ready for review and removed PR: changes requested labels Oct 30, 2025
@github-actions github-actions bot added PR: merge conflicts / rebase needed and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Nov 1, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

auto-merge was automatically disabled November 1, 2025 17:10

Head branch was pushed to by a user without write access

@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2025

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 1, 2025

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment