Update locale keys and values to use sentence casing #8182
+625
−627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
efb4f5ff-1298-471a-8973-3d47447115dc
changed the title
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
efb4f5ff-1298-471a-8973-3d47447115dc
marked this pull request as ready for review
github-actions
bot
added
the
PR: waiting for review
auto-merge was automatically disabled
November 2, 2025 19:26
Pull request was converted to draft
github-actions
bot
removed
the
PR: waiting for review
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Related issue
Closes #5000
Description
Updates all keys and values to use sentence casing to have consistent wording thought our application similar to YT. I still need to update the keys in all the other locale files and in the files where the keys are actually being used. Before i continue todo that i require some help, see Additional context section.
Testing
Additional context
Help needed on this matter: @absidue @PikachuEXE @kommunarr @ChunkyProgrammer @MarmadileManteater
This PR is drafted because of what has been described in the Description section and the following.
IMO we have a problem how keys are being used in our files and i would like to address that in this PR (allot of keys are being updated anyway so why not kill two birds with one stone). We have no consistent naming convention on how a key should be written.
Examples taken from the file:
Next chapter:KeyboardShortcutPrompt:shortcutLabelSeparator:This video is unavailable because of missing formats. This can happen due to country unavailability.:Im in favor of using camel case so that its consistent with our codebase and a nice addition is that the keys will become smaller but ofcourse still be descriptive so everyone knows what that key is used for