feat(agents): add streaming support for completions (GAP-004)#2277
feat(agents): add streaming support for completions (GAP-004)#2277
Conversation
- StreamChunk model with field descriptions - BaseGenerator.stream() with fallback to complete() - LiteLLMGenerator.stream() with real litellm streaming and proper delta-merging for incremental tool_calls - ChatWorkflow.stream_steps() async context manager - _StepRunner.execute_streaming() sharing _build_step() with execute() to reduce duplication - Refactored LiteLLMGenerator with _build_params() for DRY Made-with: Cursor
Summary of ChangesHello @Hartorn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the agent framework by integrating streaming capabilities for language model completions. This allows for more interactive and responsive agent interactions, as users can receive partial responses and observe the agent's thought process in real-time. The changes involve introducing new data models for stream chunks, extending the base generator with streaming methods, and providing a concrete streaming implementation for LiteLLM, along with a new workflow context manager to expose these features. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces comprehensive streaming support for completions, which is a valuable addition to the agents' capabilities. The changes are well-structured, including a new StreamChunk model, a default streaming implementation in BaseGenerator, and a specialized LiteLLMGenerator streaming method that correctly handles incremental tool call deltas. The refactoring of _build_params and _build_step improves code organization and reduces duplication. Furthermore, the ChatWorkflow.stream_steps() context manager provides a clean API for consuming streaming events, and the new test suite adequately covers the new functionality. Overall, the implementation is robust and well-thought-out.
Made-with: Cursor
Description
Related Issue
Type of Change
Checklist
CODE_OF_CONDUCT.mddocument.CONTRIBUTING.mdguide.pdm.lockrunningpdm update-lock(only applicable whenpyproject.tomlhas beenmodified)