feat: Add pii_detection check#2408
Open
harsh21234i wants to merge 2 commits intoGiskard-AI:mainfrom
Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces the PIIDetection check, which identifies personally identifiable information in AI responses using regex patterns, LLM evaluation, or a hybrid approach. Feedback focuses on refining the regex patterns for SSNs, credit cards, and IP addresses to reduce false positives, as well as correcting a logic error in the output resolution process that could cause runtime failures when using default settings.
Author
|
Addressed the review feedback by fixing trace fallback for output extraction and tightening the SSN, credit-card, and IPv4 regexes. Added tests for the stricter pattern behavior and reran the targeted giskard- checks suite successfully. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2374
Summary
Adds a new built-in
pii_detectioncheck togiskard-checksfordetecting personally identifiable information in model outputs.
What changed
PIIDetectionundergiskard.checks.judgesjudges/pii_detection.j2patternmodellmmodehybridmode short-circuiting on regex hitsBehavior
Supported modes:
patternllmhybridStructured categories currently handled with regex:
emailphonessncredit_cardip_addressContextual categories handled through LLM evaluation:
nameaddressmedical_infofinancial_infohybridmode first checks structured PII via regex and only falls back tothe LLM for contextual categories when needed.
Validation
Ran: