fix(agents): surface unknown workflow tool calls 🤖🤖🤖🤖#2414
Open
alexanderkreidich wants to merge 1 commit intoGiskard-AI:mainfrom
Open
fix(agents): surface unknown workflow tool calls 🤖🤖🤖🤖#2414alexanderkreidich wants to merge 1 commit intoGiskard-AI:mainfrom
alexanderkreidich wants to merge 1 commit intoGiskard-AI:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request improves error handling in the ChatWorkflow by raising a ValueError when an unknown tool is called, replacing the previous behavior of silently skipping such calls. The error message now provides helpful context, including the name of the missing tool and a list of available tools. Additionally, new test cases were added to ensure that these errors are correctly handled and reported. I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Closes #2413