Skip to content

Add Reo.Dev Integration - #298

Merged
addisonschultz merged 14 commits into
mainfrom
add-reo-integration
Jul 8, 2024
Merged

Add Reo.Dev Integration#298
addisonschultz merged 14 commits into
mainfrom
add-reo-integration

Conversation

@vibhanshub

Copy link
Copy Markdown
Contributor

No description provided.

@changeset-bot

changeset-bot Bot commented Nov 16, 2023

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 9868bdd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@addisonschultz addisonschultz left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

One request - would you mind updating the folder name from reo.dev to reo? To avoid having . in the folder name—Additionally the service is just called "Reo"

Code is looking good, we'll just wait to see where the 403 error is coming from before merging this in.

@vibhanshub
vibhanshub dismissed addisonschultz’s stale review November 17, 2023 17:20

Implemented the requested changes

@addisonschultz addisonschultz added the new-integration New integrations added to the integration platform label Apr 16, 2024
@addisonschultz

Copy link
Copy Markdown
Collaborator

Hi @vibhanshub - I've had to update the configuration and manifest based on some updates coming to sites. The context is mentioned in this PR (https://github.com/GitbookIO/integrations/pull/453/files)

This should be all that is needed, but can you review my last commit, and re-publish this integration if everything looks okay? We can keep the PR open, but just need to update the published version.

Let me know if you have any questions

Comment thread integrations/reo/gitbook-manifest.yaml Outdated
Comment thread integrations/reo/gitbook-manifest.yaml Outdated
@addisonschultz
addisonschultz requested a review from taranvohra July 8, 2024 05:53
@addisonschultz
addisonschultz merged commit c9f4cf9 into main Jul 8, 2024
@addisonschultz
addisonschultz deleted the add-reo-integration branch July 8, 2024 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-integration New integrations added to the integration platform

3 participants