Skip to content

fix(compute/gae): remove redundant mailjet_imports region tags#10295

Open
Kef131 wants to merge 1 commit into
mainfrom
refactor/remove-mailjet-snippet-markers
Open

fix(compute/gae): remove redundant mailjet_imports region tags#10295
Kef131 wants to merge 1 commit into
mainfrom
refactor/remove-mailjet-snippet-markers

Conversation

@Kef131

@Kef131 Kef131 commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Description

Fixes #
b/348423770

Removes redundant region tags (mailjet_imports and compute_mailjet_imports)

Checklist

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved
@product-auto-label product-auto-label Bot added api: compute Issues related to the Compute Engine API. samples Issues that are directly related to samples. api: appengine Issues related to the App Engine Admin API API. labels Jun 29, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes unused region tag comments for mailjet imports in both MailjetServlet.java and MailjetSender.java. There are no review comments, and I have no feedback to provide.

@angelcaamal angelcaamal left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Kef131 Kef131 marked this pull request as ready for review June 29, 2026 20:05
@Kef131 Kef131 requested review from a team and yoshi-approver as code owners June 29, 2026 20:05
@snippet-bot

snippet-bot Bot commented Jun 29, 2026

Copy link
Copy Markdown

Here is the summary of changes.

You are about to delete 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment
@product-auto-label product-auto-label Bot removed the api: appengine Issues related to the App Engine Admin API API. label Jun 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: compute Issues related to the Compute Engine API. samples Issues that are directly related to samples.

3 participants