Split test in prod or dev environment for resource limitation - #551
Open
ManfeiBai wants to merge 2 commits into
Open
Split test in prod or dev environment for resource limitation#551ManfeiBai wants to merge 2 commits into
ManfeiBai wants to merge 2 commits into
Conversation
tengyifei
approved these changes
Jan 14, 2025
tengyifei
left a comment
tengyifei
left a comment
Collaborator
There was a problem hiding this comment.
need to run formatter plz
ManfeiBai
commented
Jan 14, 2025
| with models.DAG( | ||
| dag_id="pytorch_xla_model_regression_test_on_trillium", | ||
| schedule="0 0 * * *", # everyday at midnight # job["schedule"], | ||
| schedule="0 0 * * *" if composer_env.is_prod_env() else None, # everyday at midnight # job["schedule"], |
Collaborator
Author
There was a problem hiding this comment.
hi, @RissyRan, due to other test might been set with different schedule time, so I only update test for pytorch_xla_model_regression_test_on_trillium, and please let me know if I missed anything
Collaborator
There was a problem hiding this comment.
Could you upload to an test env, and see if other child dags get benefit? I think it should work properly.
Collaborator
Author
thanks, do we mean the formatter in the CI? |
Collaborator
I think he mean this command: from here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Split test in prod or dev environment for resource limitation
Checklist
Before submitting this PR, please make sure (put X in square brackets):