Skip to content

chore: remove BigQuery Storage to_dataframe samples (moved) - #4667

Merged
busunkim96 merged 2 commits into
GoogleCloudPlatform:masterfrom
plamut:iss-4666
Sep 18, 2020
Merged

chore: remove BigQuery Storage to_dataframe samples (moved)#4667
busunkim96 merged 2 commits into
GoogleCloudPlatform:masterfrom
plamut:iss-4666

Conversation

@plamut

@plamut plamut commented Sep 11, 2020

Copy link
Copy Markdown
Contributor

Closes #4666.

These samples have been moved to the python-bigquery-storage repo and should be deleted from here.

IMPORTANT: Do not merge until the docs at cloud.google.com point to the new location

@plamut
plamut requested review from a team and shollyman as code owners September 11, 2020 08:30
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 11, 2020
@product-auto-label product-auto-label Bot added the samples Issues that are directly related to samples. label Sep 11, 2020
@plamut plamut changed the title chore: remove BigQuery Storage to_dataframe samples Sep 11, 2020
@busunkim96

Copy link
Copy Markdown
Contributor

Just opened 331776882 internally to point the docs to python-bigquery-storage. Will update once that is submitted.

@busunkim96 busunkim96 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs now reference to python-bigquery-storage repo.

@plamut

plamut commented Sep 18, 2020

Copy link
Copy Markdown
Contributor Author

Resolved merge conflict.

Edit: And again. :)

@busunkim96

Copy link
Copy Markdown
Contributor

This PR is deleting samples, and CI was green on previous runs. Admin merging.

@busunkim96
busunkim96 merged commit e992e93 into GoogleCloudPlatform:master Sep 18, 2020
@plamut
plamut deleted the iss-4666 branch September 18, 2020 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.

3 participants