-
-
Notifications
You must be signed in to change notification settings - Fork 1k
Fix undo/redo history related issues with the Path tool #3111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Performance Benchmark Results
|
|
Bug: deleting a point with Delete produces two history steps, where the intermediate step is the force deletion of the point (akin to CtrlDelete). |
|
I'm also concerned that this approach is pretty hacky and not very clean. Could you think of a way to restructure things so you're not passing around conditional flags like this? Although if that's not feasible without fully rebuilding the systems here, we can live with this for now. |
One approach is to first sanity check that under current selection some modification will be done or not (for example checking if atleast a point is selected, etc), if not then do an early return, if yes then start transaction and perform operations. |
Solving these following regressions -
Deleteand its related messages in the path tool.