Skip to content

Conversation

@4adex
Copy link
Collaborator

@4adex 4adex commented Aug 30, 2025

Solving these following regressions -

@github-actions
Copy link

github-actions bot commented Aug 30, 2025

Performance Benchmark Results

🔧 Graph Compilation

compile_demo_art_iai::compile_group::compile_to_proto with_setup_0:load_from_name(isometric-fountain)
Instructions: 22,825,374 (master) → 22,892,688 (HEAD) : $$\color{red}+0.29\%$$

Detailed metrics
Baselines:                master|       HEAD
D1mr                     286,798|    287,558          +0.26%
D1mw                      79,226|     78,929          -0.37%
DLmr                      27,875|     28,662          +2.82%
DLmw                      43,134|     42,186          -2.20%
Dr                     5,665,834|  5,686,502          +0.36%
Dw                     3,942,974|  3,956,533          +0.34%
EstimatedCycles       36,213,132| 36,341,629          +0.35%
I1mr                      39,921|     47,397         +18.73%
ILmr                         830|        831          +0.12%
Ir                    22,825,374| 22,892,688          +0.29%
L1hits                32,028,237| 32,121,839          +0.29%
LLhits                   334,106|    342,205          +2.42%
RamHits                   71,839|     71,679          -0.22%
TotalRW               32,434,182| 32,535,723          +0.31%

compile_demo_art_iai::compile_group::compile_to_proto with_setup_1:load_from_name(painted-dreams)
Instructions: 12,142,626 (master) → 12,192,398 (HEAD) : $$\color{red}+0.41\%$$

Detailed metrics
Baselines:                master|       HEAD
D1mr                     146,435|    147,278          +0.58%
D1mw                      41,852|     41,841          -0.03%
DLmr                         656|        699          +6.55%
DLmw                      15,449|     14,483          -6.25%
Dr                     2,998,071|  3,011,989          +0.46%
Dw                     2,087,089|  2,095,578          +0.41%
EstimatedCycles       18,563,978| 18,625,955          +0.33%
I1mr                      19,821|     23,271         +17.41%
ILmr                         687|        699          +1.75%
Ir                    12,142,626| 12,192,398          +0.41%
L1hits                17,019,678| 17,087,575          +0.40%
LLhits                   191,316|    196,509          +2.71%
RamHits                   16,792|     15,881          -5.43%
TotalRW               17,227,786| 17,299,965          +0.42%

compile_demo_art_iai::compile_group::compile_to_proto with_setup_2:load_from_name(procedural-string-lights)
Instructions: 1,819,339 (master) → 2,597,508 (HEAD) : $$\color{red}+42.77\%$$

Detailed metrics
Baselines:                master|       HEAD
D1mr                      18,411|     30,974         +68.24%
D1mw                       7,479|      7,855          +5.03%
DLmr                          13|         14          +7.69%
DLmw                       1,566|      2,880         +83.91%
Dr                       429,293|    635,216         +47.97%
Dw                       309,362|    441,919         +42.85%
EstimatedCycles        2,746,288|  3,956,681         +44.07%
I1mr                       4,331|      4,928         +13.78%
ILmr                         668|        673          +0.75%
Ir                     1,819,339|  2,597,508         +42.77%
L1hits                 2,527,773|  3,630,886         +43.64%
LLhits                    27,974|     40,190         +43.67%
RamHits                    2,247|      3,567         +58.74%
TotalRW                2,557,994|  3,674,643         +43.65%

compile_demo_art_iai::compile_group::compile_to_proto with_setup_3:load_from_name(parametric-dunescape)
Instructions: 12,282,042 (master) → 12,309,707 (HEAD) : $$\color{red}+0.23\%$$

Detailed metrics
Baselines:                master|       HEAD
D1mr                     159,881|    160,269          +0.24%
D1mw                      44,632|     44,694          +0.14%
DLmr                          89|         79         -11.24%
DLmw                      15,130|     14,948          -1.20%
Dr                     3,005,458|  3,012,767          +0.24%
Dw                     2,115,352|  2,120,350          +0.24%
EstimatedCycles       18,769,918| 18,812,636          +0.23%
I1mr                      17,186|     18,810          +9.45%
ILmr                         790|        797          +0.89%
Ir                    12,282,042| 12,309,707          +0.23%
L1hits                17,181,153| 17,219,051          +0.22%
LLhits                   205,690|    207,949          +1.10%
RamHits                   16,009|     15,824          -1.16%
TotalRW               17,402,852| 17,442,824          +0.23%

compile_demo_art_iai::compile_group::compile_to_proto with_setup_4:load_from_name(red-dress)
Instructions: 27,534,586 (master) → 27,606,483 (HEAD) : $$\color{red}+0.26\%$$

Detailed metrics
Baselines:                master|       HEAD
D1mr                     346,281|    348,163          +0.54%
D1mw                      93,217|     92,878          -0.36%
DLmr                      42,043|     42,680          +1.52%
DLmw                      51,062|     61,140         +19.74%
Dr                     6,801,007|  6,824,206          +0.34%
Dw                     4,738,812|  4,752,891          +0.30%
EstimatedCycles       43,826,491| 44,296,908          +1.07%
I1mr                      44,041|     52,431         +19.05%
ILmr                         826|        828          +0.24%
Ir                    27,534,586| 27,606,483          +0.26%
L1hits                38,590,866| 38,690,108          +0.26%
LLhits                   389,608|    388,824          -0.20%
RamHits                   93,931|    104,648         +11.41%
TotalRW               39,074,405| 39,183,580          +0.28%

compile_demo_art_iai::compile_group::compile_to_proto with_setup_5:load_from_name(valley-of-spires)
Instructions: 17,541,462 (master) → 17,597,228 (HEAD) : $$\color{red}+0.32\%$$

Detailed metrics
Baselines:                master|       HEAD
D1mr                     215,371|    215,250          -0.06%
D1mw                      55,548|     54,844          -1.27%
DLmr                      13,237|     13,879          +4.85%
DLmw                      30,294|     29,649          -2.13%
Dr                     4,354,971|  4,372,136          +0.39%
Dw                     3,025,969|  3,036,466          +0.35%
EstimatedCycles       27,454,180| 27,557,082          +0.37%
I1mr                      29,753|     35,514         +19.36%
ILmr                         772|        766          -0.78%
Ir                    17,541,462| 17,597,228          +0.32%
L1hits                24,621,730| 24,700,222          +0.32%
LLhits                   256,369|    261,314          +1.93%
RamHits                   44,303|     44,294          -0.02%
TotalRW               24,922,402| 25,005,830          +0.33%

🔄 Executor Update

update_executor_iai::update_group::update_executor with_setup_0:setup_update_executor(isometric-fountain)
Instructions: 41,149,024 (master) → 41,159,971 (HEAD) : $$\color{red}+0.03\%$$

Detailed metrics
Baselines:                master|       HEAD
D1mr                     450,245|    455,242          +1.11%
D1mw                      98,821|     99,880          +1.07%
DLmr                       9,231|      8,852          -4.11%
DLmw                      30,060|     27,473          -8.61%
Dr                    10,462,363| 10,463,460          +0.01%
Dw                     7,078,606|  7,082,719          +0.06%
EstimatedCycles       62,307,487| 62,158,204          -0.24%
I1mr                      58,420|     33,399         -42.83%
ILmr                         294|        274          -6.80%
Ir                    41,149,024| 41,159,971          +0.03%
L1hits                58,082,507| 58,117,629          +0.06%
LLhits                   567,901|    551,922          -2.81%
RamHits                   39,585|     36,599          -7.54%
TotalRW               58,689,993| 58,706,150          +0.03%

update_executor_iai::update_group::update_executor with_setup_1:setup_update_executor(painted-dreams)
Instructions: 22,780,734 (master) → 22,793,790 (HEAD) : $$\color{red}+0.06\%$$

Detailed metrics
Baselines:                master|       HEAD
D1mr                     238,490|    237,210          -0.54%
D1mw                      52,665|     52,186          -0.91%
DLmr                         986|        934          -5.27%
DLmw                      12,616|     12,791          +1.39%
Dr                     5,746,196|  5,749,786          +0.06%
Dw                     3,905,041|  3,911,236          +0.16%
EstimatedCycles       34,163,051| 34,109,232          -0.16%
I1mr                      38,040|     19,764         -48.04%
ILmr                         208|        201          -3.37%
Ir                    22,780,734| 22,793,790          +0.06%
L1hits                32,102,776| 32,145,652          +0.13%
LLhits                   315,385|    295,234          -6.39%
RamHits                   13,810|     13,926          +0.84%
TotalRW               32,431,971| 32,454,812          +0.07%

update_executor_iai::update_group::update_executor with_setup_2:setup_update_executor(procedural-string-lights)
Instructions: 4,708,508 (master) → 4,860,106 (HEAD) : $$\color{red}+3.22\%$$

Detailed metrics
Baselines:                master|       HEAD
D1mr                      45,385|     49,019          +8.01%
D1mw                      11,119|     11,464          +3.10%
DLmr                           2|          2          +0.00%
DLmw                         324|        698        +115.43%
Dr                     1,166,245|  1,226,464          +5.16%
Dw                       785,720|    833,545          +6.09%
EstimatedCycles        6,933,119|  7,209,287          +3.98%
I1mr                       7,720|      5,045         -34.65%
ILmr                         199|        202          +1.51%
Ir                     4,708,508|  4,860,106          +3.22%
L1hits                 6,596,249|  6,854,587          +3.92%
LLhits                    63,699|     64,626          +1.46%
RamHits                      525|        902         +71.81%
TotalRW                6,660,473|  6,920,115          +3.90%

update_executor_iai::update_group::update_executor with_setup_3:setup_update_executor(parametric-dunescape)
Instructions: 18,951,654 (master) → 18,944,991 (HEAD) : $$\color{lime}-0.04\%$$

Detailed metrics
Baselines:                master|       HEAD
D1mr                     185,535|    184,088          -0.78%
D1mw                      46,355|     45,837          -1.12%
DLmr                         113|        116          +2.65%
DLmw                       6,270|      6,081          -3.01%
Dr                     4,734,397|  4,733,242          -0.02%
Dw                     3,248,198|  3,247,023          -0.04%
EstimatedCycles       28,165,869| 28,099,458          -0.24%
I1mr                      26,740|     15,798         -40.92%
ILmr                         187|        180          -3.74%
Ir                    18,951,654| 18,944,991          -0.04%
L1hits                26,675,619| 26,679,533          +0.01%
LLhits                   252,060|    239,346          -5.04%
RamHits                    6,570|      6,377          -2.94%
TotalRW               26,934,249| 26,925,256          -0.03%

update_executor_iai::update_group::update_executor with_setup_4:setup_update_executor(red-dress)
Instructions: 51,216,444 (master) → 51,166,941 (HEAD) : $$\color{lime}-0.10\%$$

Detailed metrics
Baselines:                master|       HEAD
D1mr                     552,864|    539,970          -2.33%
D1mw                     127,381|    127,554          +0.14%
DLmr                      16,901|     19,729         +16.73%
DLmw                      45,451|     43,918          -3.37%
Dr                    13,151,800| 13,140,090          -0.09%
Dw                     9,031,508|  9,016,146          -0.17%
EstimatedCycles       78,295,824| 78,065,767          -0.29%
I1mr                      73,898|     38,281         -48.20%
ILmr                         298|        332         +11.41%
Ir                    51,216,444| 51,166,941          -0.10%
L1hits                72,645,609| 72,617,372          -0.04%
LLhits                   691,493|    641,826          -7.18%
RamHits                   62,650|     63,979          +2.12%
TotalRW               73,399,752| 73,323,177          -0.10%

update_executor_iai::update_group::update_executor with_setup_5:setup_update_executor(valley-of-spires)
Instructions: 32,757,313 (master) → 32,771,360 (HEAD) : $$\color{red}+0.04\%$$

Detailed metrics
Baselines:                master|       HEAD
D1mr                     362,019|    362,073          +0.01%
D1mw                      79,929|     79,710          -0.27%
DLmr                       4,489|      3,957         -11.85%
DLmw                      24,340|     23,053          -5.29%
Dr                     8,331,752|  8,335,221          +0.04%
Dw                     5,652,743|  5,655,077          +0.04%
EstimatedCycles       49,573,274| 49,448,772          -0.25%
I1mr                      48,096|     25,823         -46.31%
ILmr                         214|        213          -0.47%
Ir                    32,757,313| 32,771,360          +0.04%
L1hits                46,251,764| 46,294,052          +0.09%
LLhits                   461,001|    440,383          -4.47%
RamHits                   29,043|     27,223          -6.27%
TotalRW               46,741,808| 46,761,658          +0.04%

🚀 Render: Cold Execution

run_once_iai::run_once_group::run_once with_setup_0:setup_run_once(isometric-fountain)
Instructions: 21,111,621 (master) → 20,673,074 (HEAD) : $$\color{lime}-2.08\%$$

Detailed metrics
Baselines:                master|       HEAD
D1mr                     239,055|    235,085          -1.66%
D1mw                      51,532|     49,951          -3.07%
DLmr                      12,127|     11,339          -6.50%
DLmw                      15,901|     15,577          -2.04%
Dr                     5,372,370|  5,256,528          -2.16%
Dw                     3,590,913|  3,509,235          -2.27%
EstimatedCycles       32,735,186| 31,986,891          -2.29%
I1mr                     126,616|    113,935         -10.02%
ILmr                       5,021|      4,823          -3.94%
Ir                    21,111,621| 20,673,074          -2.08%
L1hits                29,657,701| 29,039,866          -2.08%
LLhits                   384,154|    367,232          -4.41%
RamHits                   33,049|     31,739          -3.96%
TotalRW               30,074,904| 29,438,837          -2.11%

run_once_iai::run_once_group::run_once with_setup_1:setup_run_once(painted-dreams)
Instructions: 77,739,259 (master) → 76,780,016 (HEAD) : $$\color{lime}-1.23\%$$

Detailed metrics
Baselines:                master|       HEAD
D1mr                     397,494|    389,414          -2.03%
D1mw                     187,423|    181,398          -3.21%
DLmr                       5,921|      5,027         -15.10%
DLmw                      50,317|     47,587          -5.43%
Dr                    18,499,766| 18,171,492          -1.77%
Dw                    12,446,368| 12,191,967          -2.04%
EstimatedCycles      113,697,923|111,882,539          -1.60%
I1mr                     191,868|    166,489         -13.23%
ILmr                       7,275|      7,048          -3.12%
Ir                    77,739,259| 76,780,016          -1.23%
L1hits               107,908,608|106,406,174          -1.39%
LLhits                   713,272|    677,639          -5.00%
RamHits                   63,513|     59,662          -6.06%
TotalRW              108,685,393|107,143,475          -1.42%

run_once_iai::run_once_group::run_once with_setup_2:setup_run_once(procedural-string-lights)
Instructions: 9,871,708 (master) → 9,566,084 (HEAD) : $$\color{lime}-3.10\%$$

Detailed metrics
Baselines:                master|       HEAD
D1mr                      38,509|     38,789          +0.73%
D1mw                      17,098|     16,409          -4.03%
DLmr                         226|        267         +18.14%
DLmw                       3,903|      3,444         -11.76%
Dr                     2,278,475|  2,183,690          -4.16%
Dw                     1,583,899|  1,514,455          -4.38%
EstimatedCycles       14,392,818| 13,857,215          -3.72%
I1mr                      46,257|     34,331         -25.78%
ILmr                       4,247|      4,118          -3.04%
Ir                     9,871,708|  9,566,084          -3.10%
L1hits                13,632,218| 13,174,700          -3.36%
LLhits                    93,488|     81,700         -12.61%
RamHits                    8,376|      7,829          -6.53%
TotalRW               13,734,082| 13,264,229          -3.42%

run_once_iai::run_once_group::run_once with_setup_3:setup_run_once(parametric-dunescape)
Instructions: 26,433,768 (master) → 26,302,428 (HEAD) : $$\color{lime}-0.50\%$$

Detailed metrics
Baselines:                master|       HEAD
D1mr                     124,952|    120,488          -3.57%
D1mw                      54,633|     50,326          -7.88%
DLmr                       1,496|      1,572          +5.08%
DLmw                      10,106|     10,645          +5.33%
Dr                     5,905,364|  5,856,644          -0.83%
Dw                     3,528,100|  3,486,984          -1.17%
EstimatedCycles       37,301,302| 37,043,848          -0.69%
I1mr                      66,005|     61,994          -6.08%
ILmr                       3,455|      3,335          -3.47%
Ir                    26,433,768| 26,302,428          -0.50%
L1hits                35,621,642| 35,413,248          -0.59%
LLhits                   230,533|    217,256          -5.76%
RamHits                   15,057|     15,552          +3.29%
TotalRW               35,867,232| 35,646,056          -0.62%

run_once_iai::run_once_group::run_once with_setup_4:setup_run_once(red-dress)
Instructions: 1,901,433,313 (master) → 1,884,413,252 (HEAD) : $$\color{lime}-0.90\%$$

Detailed metrics
Baselines:                master|       HEAD
D1mr                   1,555,060|  1,532,356          -1.46%
D1mw                     709,661|    699,139          -1.48%
DLmr                     330,292|    324,935          -1.62%
DLmw                     454,858|    444,365          -2.31%
Dr                   441,583,789|437,091,462          -1.02%
Dw                   281,938,920|278,920,323          -1.07%
EstimatedCycles      2,662,602,458|2,635,872,681          -1.00%
I1mr                   1,217,148|    822,401         -32.43%
ILmr                       5,482|      5,102          -6.93%
Ir                   1,901,433,313|1,884,413,252          -0.90%
L1hits               2,621,474,153|2,597,371,141          -0.92%
LLhits                 2,691,237|  2,279,494         -15.30%
RamHits                  790,632|    774,402          -2.05%
TotalRW              2,624,956,022|2,600,425,037          -0.93%

run_once_iai::run_once_group::run_once with_setup_5:setup_run_once(valley-of-spires)
Instructions: 19,412,612 (master) → 19,106,990 (HEAD) : $$\color{lime}-1.57\%$$

Detailed metrics
Baselines:                master|       HEAD
D1mr                     194,229|    193,126          -0.57%
D1mw                      45,085|     44,134          -2.11%
DLmr                       5,559|      5,686          +2.28%
DLmw                      11,937|     12,533          +4.99%
Dr                     4,734,888|  4,667,257          -1.43%
Dw                     3,137,677|  3,096,517          -1.31%
EstimatedCycles       29,272,055| 28,831,206          -1.51%
I1mr                     102,253|     93,108          -8.94%
ILmr                       3,191|      3,080          -3.48%
Ir                    19,412,612| 19,106,990          -1.57%
L1hits                26,943,610| 26,540,396          -1.50%
LLhits                   320,880|    309,069          -3.68%
RamHits                   20,687|     21,299          +2.96%
TotalRW               27,285,177| 26,870,764          -1.52%

⚡ Render: Cached Execution

run_cached_iai::run_cached_group::run_cached with_setup_0:setup_run_cached(isometric-fountain)
Instructions: 21,221,688 (master) → 20,790,638 (HEAD) : $$\color{lime}-2.03\%$$

Detailed metrics
Baselines:                master|       HEAD
D1mr                     256,397|    251,684          -1.84%
D1mw                      46,899|     45,326          -3.35%
DLmr                       5,560|      4,318         -22.34%
DLmw                         731|        730          -0.14%
Dr                     5,483,167|  5,347,188          -2.48%
Dw                     3,633,844|  3,529,875          -2.86%
EstimatedCycles       32,248,167| 31,470,153          -2.41%
I1mr                     125,711|    114,528          -8.90%
ILmr                         157|        162          +3.18%
Ir                    21,221,688| 20,790,638          -2.03%
L1hits                29,909,692| 29,256,163          -2.19%
LLhits                   422,559|    406,328          -3.84%
RamHits                    6,448|      5,210         -19.20%
TotalRW               30,338,699| 29,667,701          -2.21%

run_cached_iai::run_cached_group::run_cached with_setup_1:setup_run_cached(painted-dreams)
Instructions: 27,319,129 (master) → 26,367,056 (HEAD) : $$\color{lime}-3.49\%$$

Detailed metrics
Baselines:                master|       HEAD
D1mr                     228,077|    220,628          -3.27%
D1mw                      60,220|     55,027          -8.62%
DLmr                       2,322|      1,434         -38.24%
DLmw                       1,518|      2,020         +33.07%
Dr                     6,798,076|  6,507,764          -4.27%
Dw                     4,659,876|  4,445,940          -4.59%
EstimatedCycles       40,448,561| 38,842,012          -3.97%
I1mr                      99,498|     77,613         -22.00%
ILmr                         170|        152         -10.59%
Ir                    27,319,129| 26,367,056          -3.49%
L1hits                38,389,286| 36,967,492          -3.70%
LLhits                   383,785|    349,662          -8.89%
RamHits                    4,010|      3,606         -10.07%
TotalRW               38,777,081| 37,320,760          -3.76%

run_cached_iai::run_cached_group::run_cached with_setup_2:setup_run_cached(procedural-string-lights)
Instructions: 9,490,597 (master) → 9,198,662 (HEAD) : $$\color{lime}-3.08\%$$

Detailed metrics
Baselines:                master|       HEAD
D1mr                      49,095|     47,658          -2.93%
D1mw                      15,044|     15,748          +4.68%
DLmr                           7|          7          +0.00%
DLmw                         250|        377         +50.80%
Dr                     2,211,716|  2,187,239          -1.11%
Dw                     1,532,595|  1,541,535          +0.58%
EstimatedCycles       13,680,154| 13,329,328          -2.56%
I1mr                      44,030|     33,032         -24.98%
ILmr                         162|        154          -4.94%
Ir                     9,490,597|  9,198,662          -3.08%
L1hits                13,126,739| 12,830,998          -2.25%
LLhits                   107,750|     95,900         -11.00%
RamHits                      419|        538         +28.40%
TotalRW               13,234,908| 12,927,436          -2.32%

run_cached_iai::run_cached_group::run_cached with_setup_3:setup_run_cached(parametric-dunescape)
Instructions: 16,334,944 (master) → 16,148,298 (HEAD) : $$\color{lime}-1.14\%$$

Detailed metrics
Baselines:                master|       HEAD
D1mr                     108,553|    105,192          -3.10%
D1mw                      39,075|     35,477          -9.21%
DLmr                          41|         43          +4.88%
DLmw                       1,001|      1,015          +1.40%
Dr                     3,738,836|  3,653,240          -2.29%
Dw                     2,496,171|  2,418,265          -3.12%
EstimatedCycles       23,307,533| 22,921,647          -1.66%
I1mr                      28,075|     26,017          -7.33%
ILmr                         117|        112          -4.27%
Ir                    16,334,944| 16,148,298          -1.14%
L1hits                22,394,248| 22,053,117          -1.52%
LLhits                   174,544|    165,516          -5.17%
RamHits                    1,159|      1,170          +0.95%
TotalRW               22,569,951| 22,219,803          -1.55%

run_cached_iai::run_cached_group::run_cached with_setup_4:setup_run_cached(red-dress)
Instructions: 296,343,697 (master) → 280,094,479 (HEAD) : $$\color{lime}-5.48\%$$

Detailed metrics
Baselines:                master|       HEAD
D1mr                   1,465,317|  1,427,009          -2.61%
D1mw                     468,629|    461,178          -1.59%
DLmr                     503,514|    489,481          -2.79%
DLmw                     224,819|    228,079          +1.45%
Dr                    72,438,881| 68,143,216          -5.93%
Dw                    51,874,114| 48,967,838          -5.60%
EstimatedCycles      454,922,932|429,591,079          -5.57%
I1mr                   1,138,789|    795,952         -30.11%
ILmr                       4,177|      4,073          -2.49%
Ir                   296,343,697|280,094,479          -5.48%
L1hits               417,583,957|394,521,394          -5.52%
LLhits                 2,340,225|  1,962,506         -16.14%
RamHits                  732,510|    721,633          -1.48%
TotalRW              420,656,692|397,205,533          -5.57%

run_cached_iai::run_cached_group::run_cached with_setup_5:setup_run_cached(valley-of-spires)
Instructions: 19,714,993 (master) → 19,421,961 (HEAD) : $$\color{lime}-1.49\%$$

Detailed metrics
Baselines:                master|       HEAD
D1mr                     209,393|    206,818          -1.23%
D1mw                      41,414|     39,891          -3.68%
DLmr                         271|        400         +47.60%
DLmw                       1,261|        681         -46.00%
Dr                     4,869,585|  4,786,826          -1.70%
Dw                     3,192,771|  3,134,615          -1.82%
EstimatedCycles       29,252,181| 28,753,906          -1.70%
I1mr                     105,301|     96,692          -8.18%
ILmr                         148|        149          +0.68%
Ir                    19,714,993| 19,421,961          -1.49%
L1hits                27,421,241| 27,000,001          -1.54%
LLhits                   354,428|    342,171          -3.46%
RamHits                    1,680|      1,230         -26.79%
TotalRW               27,777,349| 27,343,402          -1.56%
@Keavon
Copy link
Member

Keavon commented Aug 31, 2025

Bug: deleting a point with Delete produces two history steps, where the intermediate step is the force deletion of the point (akin to CtrlDelete).

@Keavon
Copy link
Member

Keavon commented Aug 31, 2025

I'm also concerned that this approach is pretty hacky and not very clean. Could you think of a way to restructure things so you're not passing around conditional flags like this? Although if that's not feasible without fully rebuilding the systems here, we can live with this for now.

@Keavon Keavon marked this pull request as draft August 31, 2025 00:29
@Keavon Keavon changed the title Path Tool: Fix transaction messages Aug 31, 2025
@4adex
Copy link
Collaborator Author

4adex commented Sep 5, 2025

Could you think of a way to restructure things so you're not passing around conditional flags like this?

One approach is to first sanity check that under current selection some modification will be done or not (for example checking if atleast a point is selected, etc), if not then do an early return, if yes then start transaction and perform operations.
But this will require adding more checker functions in the code.

@Keavon Keavon changed the title Fix history transaction issues in the Path tool Sep 11, 2025
@Keavon Keavon changed the title Fix history transaction related issues in the Path tool Sep 11, 2025
@Keavon Keavon changed the title Fix undo/redo history related issues in the Path tool Sep 11, 2025
@Keavon Keavon enabled auto-merge (squash) September 11, 2025 04:18
@Keavon Keavon merged commit 09ece94 into master Sep 11, 2025
4 checks passed
@Keavon Keavon deleted the fix_path_tool branch September 11, 2025 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants