Skip to content

Fix text strings in menu factory implementations #6753

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 30, 2024
Merged

Fix text strings in menu factory implementations #6753

merged 1 commit into from
Nov 30, 2024

Conversation

@pethers
Copy link
Member

@pethers pethers commented Nov 30, 2024 •
edited
Loading

Replace all instances of "Desc." with suitable short descriptions and move hardcoded text to constants in the specified classes.

  • GovernmentBodyMenuItemFactoryImpl.java

    • Replace 'Desc.' with "Chart showing the headcount of the government body", "Chart showing the income of the government body", and "Chart showing the expenditure of the government body".
    • Move the hardcoded text strings to constants by declaring them as private static final String.

  • GovernmentBodyRankingMenuItemFactoryImpl.java

    • Replace 'Desc.' with "Chart showing the headcount of government bodies", "Chart showing the income of government bodies", and "Chart showing the expenditure of government bodies".
    • Move the hardcoded text strings to constants by declaring them as private static final String.

  • ApplicationMenuItemFactoryImpl.java

    • Improve the createOverviewPage method by ensuring all hardcoded text strings are moved to constants.
    • Ensure the descriptions are clear and concise, providing a brief summary of the content.

  • BallotMenuItemFactoryImpl.java

    • Replace 'Desc.' with "Breakdown by total votes and by party".
    • Move the hardcoded text strings to constants by declaring them as private static final String.

  • CommitteeMenuItemFactoryImpl.java

    • Replace 'Desc.' with suitable short descriptions for various elements.
    • Move the hardcoded text strings to constants by declaring them as private static final String.

  • CountryMenuItemFactoryImpl.java

    • Replace 'Desc.' with "Indicators for Sweden overview, find data by topic or source".
    • Move the hardcoded text strings to constants by declaring them as private static final String.

  • DocumentMenuItemFactoryImpl.java

    • Replace 'Desc.' with suitable short descriptions for various elements.
    • Move the hardcoded text strings to constants by declaring them as private static final String.

  • MinistryMenuItemFactoryImpl.java

    • Replace 'Desc.' with suitable short descriptions for various elements.
    • Move the hardcoded text strings to constants by declaring them as private static final String.

For more details, open the Copilot Workspace session.
@pethers
Fix text strings in menu factory implementations
d70da46 
Replace all instances of "Desc." with suitable short descriptions and move hardcoded text to constants in the specified classes.

* **GovernmentBodyMenuItemFactoryImpl.java**
  - Replace 'Desc.' with "Chart showing the headcount of the government body", "Chart showing the income of the government body", and "Chart showing the expenditure of the government body".
  - Move the hardcoded text strings to constants by declaring them as `private static final String`.

* **GovernmentBodyRankingMenuItemFactoryImpl.java**
  - Replace 'Desc.' with "Chart showing the headcount of government bodies", "Chart showing the income of government bodies", and "Chart showing the expenditure of government bodies".
  - Move the hardcoded text strings to constants by declaring them as `private static final String`.

* **ApplicationMenuItemFactoryImpl.java**
  - Improve the `createOverviewPage` method by ensuring all hardcoded text strings are moved to constants.
  - Ensure the descriptions are clear and concise, providing a brief summary of the content.

* **BallotMenuItemFactoryImpl.java**
  - Replace 'Desc.' with "Breakdown by total votes and by party".
  - Move the hardcoded text strings to constants by declaring them as `private static final String`.

* **CommitteeMenuItemFactoryImpl.java**
  - Replace 'Desc.' with suitable short descriptions for various elements.
  - Move the hardcoded text strings to constants by declaring them as `private static final String`.

* **CountryMenuItemFactoryImpl.java**
  - Replace 'Desc.' with "Indicators for Sweden overview, find data by topic or source".
  - Move the hardcoded text strings to constants by declaring them as `private static final String`.

* **DocumentMenuItemFactoryImpl.java**
  - Replace 'Desc.' with suitable short descriptions for various elements.
  - Move the hardcoded text strings to constants by declaring them as `private static final String`.

* **MinistryMenuItemFactoryImpl.java**
  - Replace 'Desc.' with suitable short descriptions for various elements.
  - Move the hardcoded text strings to constants by declaring them as `private static final String`.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/Hack23/cia?shareId=XXXX-XXXX-XXXX-XXXX).
@github-actions
Copy link

github-actions bot commented Nov 30, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA d70da46.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files
@pethers pethers merged commit e556e1d into master Nov 30, 2024
5 checks passed
@pethers pethers deleted the pethers/fix-text-strings branch November 30, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/L

2 participants

@pethers