feat: scoped app access to notifications (PUT-1684) - #3688
Open
Salazareo wants to merge 1 commit into
Open
Conversation
An actor holding an app reads the `app-user` rows naming that app, plus its `developer` rows when the holder owns it. `account` rows reach no app, and a slice an actor may not see comes back empty rather than refused. The audience predicate becomes the enforced read path in the same change that lifts the blanket app-actor 403, layered behind an audience/app_uid SQL scope; two-segment `notif:` subjects expand server-side from the actor's own app, so an app can never name another app's uid. No feature flag: `audience` defaults to 'account', so every pre-registry row is default-denied to app actors and the backfill can only narrow.
Salazareo
force-pushed
the
DS/put-1684
branch
from
September 1, 2026 07:02
4a52cb2 to
c8c2625
Compare
Salazareo
force-pushed
the
DS/put-1684
branch
from
September 1, 2026 07:04
c8c2625 to
4a52cb2
Compare
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An actor holding an app reads the
app-userrows naming that app, plus itsdeveloperrows when the holder owns it.accountrows reach no app, and aslice an actor may not see comes back empty rather than refused. The audience
predicate becomes the enforced read path in the same change that lifts the
blanket app-actor 403, layered behind an audience/app_uid SQL scope; two-segment
notif:subjects expand server-side from the actor's own app, so an app cannever name another app's uid.
No feature flag:
audiencedefaults to 'account', so every pre-registry row isdefault-denied to app actors and the backfill can only narrow.
Stacked on
DS/put-1681— review only this PR's diff; merges bottom-up.