Fix Shortcode context for v2 blocks#2919
Merged
gcushen merged 1 commit intoHugoBlox:mainfrom Feb 13, 2023
Merged
Conversation
✅ Deploy Preview for hugo-portfolio-theme canceled.
|
✅ Deploy Preview for markdown-slides canceled.
|
Collaborator
|
Thanks for contributing a solution 🎉 Before we merge this, can you check if we still need to include the |
Contributor
Author
|
I tried, but |
gcushen
approved these changes
Feb 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Shortcodes in the new block system do not get access to the correct
.Pagevariable (see #2918 ). The problem is the use ofmarkdownifyfunction to parse$block.content.text, since it actually is an alias tosite.Home.RenderStringsince v 0.93.0 (see gohugoio/hugo#9959 (comment)).This causes the shortcodes to always get the Homepage as
.Pagevariable. The fix is to substitutemarkdownifywith$page.RenderString, which gives the correct context.An actual example of this behaviour can be found in this branch (in the
csvpage):This PR fixes #2918.