Skip to content

refactor: remove JQuery from parts of Search JS#2970

Merged
gcushen merged 2 commits intoHugoBlox:mainfrom
Konafets:remove_jquery
Aug 11, 2023
Merged

refactor: remove JQuery from parts of Search JS#2970
gcushen merged 2 commits intoHugoBlox:mainfrom
Konafets:remove_jquery

Conversation

@Konafets
Copy link
Copy Markdown
Contributor

@Konafets Konafets commented Aug 2, 2023 •
edited by gcushen
Loading

Towards achieving #1402
@netlify
Copy link
Copy Markdown

netlify Bot commented Aug 2, 2023 •
edited
Loading

✅ Deploy Preview for hugo-portfolio-theme canceled.

Name Link
🔨 Latest commit b5aa213
🔍 Latest deploy log https://app.netlify.com/sites/hugo-portfolio-theme/deploys/64d6766aa77a67000805b6cc
@netlify
Copy link
Copy Markdown

netlify Bot commented Aug 2, 2023 •
edited
Loading

✅ Deploy Preview for academic-demo canceled.

Name Link
🔨 Latest commit b5aa213
🔍 Latest deploy log https://app.netlify.com/sites/academic-demo/deploys/64d6766a1ab4e10008bd84c6
@netlify
Copy link
Copy Markdown

netlify Bot commented Aug 2, 2023 •
edited
Loading

✅ Deploy Preview for markdown-slides canceled.

Name Link
🔨 Latest commit b5aa213
🔍 Latest deploy log https://app.netlify.com/sites/markdown-slides/deploys/64d6766a0a99360008a2ca7f
@Konafets Konafets changed the title Remove jquery Aug 2, 2023
gcushen
gcushen requested changes Aug 2, 2023
View reviewed changes
Comment thread modules/wowchemy/assets/js/wowchemy.js Outdated
document.querySelector('#TableOfContents').classList.add('nav flex-column');
}
if (document.querySelector('#TableOfContents li')) {
document.querySelector('#TableOfContents li').classList.add('nav-item');
Copy link
Copy Markdown
Collaborator

@gcushen gcushen Aug 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There can be multiple <li>, so surely this requires a foreach statement?

Similar feedback applies to the other instances where the query selector matches multiple elements.
Copy link
Copy Markdown
Collaborator

@gcushen gcushen Aug 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested all these changes?
Copy link
Copy Markdown
Collaborator

@gcushen gcushen Aug 5, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Konafets I see you have pushed some more changes but have not responded to the above comments yet?

Do the new commits fix all the issues and have you now tested that the PR works?
Copy link
Copy Markdown
Contributor Author

@Konafets Konafets Aug 6, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,

yes after your question I get back and tested all changes successfully. This means, multiple tables are handled correctly, the table of content and the checkboxes get the bullets removed. From my tests, it works like it did before.
@Konafets Konafets force-pushed the remove_jquery branch 2 times, most recently from bc6ff79 to 02083a9 Compare August 3, 2023 09:08
gcushen
gcushen requested changes Aug 7, 2023
View reviewed changes
Comment thread modules/wowchemy/assets/js/wowchemy.js Outdated
@gcushen gcushen merged commit f2a7bd1 into HugoBlox:main Aug 11, 2023
@gcushen gcushen changed the title Remove some low hanging JQuery fruits Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement

2 participants

@Konafets @gcushen