Skip to content

Added "automapping" feature for environment variables#60

Open
phansys wants to merge 4 commits intoIncenteev:masterfrom
phansys:master
Open

Added "automapping" feature for environment variables#60
phansys wants to merge 4 commits intoIncenteev:masterfrom
phansys:master

Conversation

@phansys
Copy link
Copy Markdown

@phansys phansys commented Jul 16, 2014

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes

For more details, see README.md.
@stof
Copy link
Copy Markdown
Member

stof commented Jul 16, 2014

I will need a bit of time to review this in detail (I don't have this time right now), but the feature looks interesting
@phansys
Copy link
Copy Markdown
Author

phansys commented Jul 16, 2014

Thank you @stof.
Take your time.
@phansys phansys force-pushed the master branch 3 times, most recently from e828133 to 42ba5d8 Compare September 17, 2014 02:15
@kcivey
Copy link
Copy Markdown

kcivey commented Oct 23, 2014

It seems like this would be better done with a prefix (or at least an option for having one) the way Symfony does it (along with translating double underscore to dot):
http://symfony.com/doc/current/cookbook/configuration/external_parameters.html

The prefix could be defined in the incenteev-parameters.
@phansys
Copy link
Copy Markdown
Author

phansys commented Oct 23, 2014

I agree with your comment @kcivey. If @stof also agree, I could apply this change. This would be something like env-prefix or similar.
@phansys phansys closed this Oct 23, 2014
@phansys phansys reopened this Oct 23, 2014
@fouzes fouzes mentioned this pull request Oct 7, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@phansys @stof @kcivey