-
Notifications
You must be signed in to change notification settings - Fork 11
improvement: add e2e tests poc #91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
add db xxx Use yaml struct instead, add backend Add env vars wrong img Map volume built in marshall Fix volume Generate client Add makefile Add compose helper More helper More helper Use new helper Remove unused stuff get mapped port Get port and host Add provisioner Add more helpers Fix provisioning xxx Simple test Fix cookies not passed in issue Refine code Extract helper use helper Map to a random port instead Cleanup Add machine identity & token Register id Update identity to allow token auth Set default up timeout to 120 instead Add operation id Update deps Test relay start Set temp dir as home Fix api url Allow private ip Try to add relays Get relays Add logs Add TODO Extract method Fix tests Fix asserts Fix assert Address feedbacks Add execute context
7e8e11c to
8af2351
Compare
Greptile Summary
Important Files Changed
Confidence score: 4/5
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
16 files reviewed, 7 comments
| return | ||
| } | ||
|
|
||
| stderr := cmd.Stderr() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be stdout right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope, stdout is ually for output data or result of the cmd. Usually people use stderr to output the logs or system info. We are using stderr to output the logs, so this is actually correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Interesting!
Description 📣
ref: https://linear.app/infisical/issue/PLATFRM-125/update-the-current-poc-with-design-doc-feedbacks
Type ✨
Tests 🛠️
# Here's some code block to paste some code snippets