Skip to content

Pin Vale to 3.14.2 to fix dicpath resolution regression - #916

Closed
rrrutledge wants to merge 1 commit into
mainfrom
fix-vale-dicpath-pin
Closed

Pin Vale to 3.14.2 to fix dicpath resolution regression#916
rrrutledge wants to merge 1 commit into
mainfrom
fix-vale-dicpath-pin

Conversation

@rrrutledge

Copy link
Copy Markdown
Contributor

Summary

The Spelling & Styles workflow has failed on every PR (and the monthly main schedule run) since 2026-06-15, with vale erroring unable to resolve dicpath on .github/vale/ISC/Spelling.yml — unrelated to any PR's content.

Root cause

vale-action@v2 defaults to version: latest. Vale 3.15.0 (released 2026-06-12) changed vale sync to create and use the configured StylesPath (.github/vale) instead of falling back to a global styles directory (vale-cli/vale#1106). That changed where the ISC package's nested styles/ISC/Spelling.yml and styles/dictionaries/ land once synced, breaking Spelling.yml's relative dicpath: dictionaries.

3.14.2 was the last Vale release before that sync change — pinning to it restores the working layout. The isc-styles package itself hasn't changed since 2025-08-28, so this is a Vale-version compatibility issue, not a content or package issue.

Fix

Pin vale-action's version input to 3.14.2 instead of floating on latest.

Longer-term

isc-styles' Spelling.yml/dicpath should eventually be restructured to work under the new (correct) sync behavior so we can move off the pin — filing that separately against isc-styles.

Test plan

  • This PR's own Spelling & Styles check should now pass (self-verifying, since pull_request runs the workflow from this branch).
Vale 3.15.0 (released 2026-06-12) changed vale sync to create and use
the configured StylesPath instead of falling back to a global styles
directory (vale-cli/vale#1105/#1106). That changed where the ISC
style package's nested styles/ISC/Spelling.yml and styles/dictionaries
land under .github/vale, breaking Spelling.yml's relative `dicpath:
dictionaries` and failing every Spelling & Styles run since with
"unable to resolve dicpath" - unrelated to any PR's content. 3.14.2
was the last version where sync resolved dicpath correctly.
@rrrutledge

Copy link
Copy Markdown
Contributor Author

Closing in favor of the real fix at the source: InnerSourceCommons/isc-styles#4. That removes the stray StylesPath line causing the dicpath failure, so every consumer (this repo, InnerSourceLearningPath, managing-innersource-projects) is fixed once it merges — no per-repo pin needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant