Skip to content

fix: make unknown tab commands no-ops - #26

Open
ddebowczyk wants to merge 1 commit into
Jeshwin:mainfrom
ddebowczyk:fix/reject-invalid-tab-commands
Open

fix: make unknown tab commands no-ops#26
ddebowczyk wants to merge 1 commit into
Jeshwin:mainfrom
ddebowczyk:fix/reject-invalid-tab-commands

Conversation

@ddebowczyk

Copy link
Copy Markdown

Summary

  • resolve tiled and floating tabs by ID before selecting or removing them
  • reject unknown tab IDs without changing state or selection
  • use the stored tab position when repairing selection after removal
  • preserve same-reference no-op behavior for rejected commands

Validation

  • npm test -- --run tests/reducer.test.ts
  • NODE_OPTIONS=--localstorage-file=/tmp/react-layman-pr01-localstorage.json npm test
  • npx --no-install tsc --noEmit
  • npm run lint
  • npm run build:lib

Known baseline issue

Plain npm test on the current Node runtime still fails only in the existing localStorage test setup. The dedicated portability repair is planned as PR 04; this branch does not change persistence behavior.

@ddebowczyk
ddebowczyk force-pushed the fix/reject-invalid-tab-commands branch 2 times, most recently from c94b057 to 818a072 Compare August 12, 2026 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant