Fix: repeater tick not scheduling at the end of the tick #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
It seems tests have failed, I almost forgot we had those, so i'l need to figure out what goes wrong here and probably need to do some more tests before this can be merged |
Member
|
This is a risky change. I would be interested in seeing a concrete example of a build being affected by this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an inconsistency between the normal ticking and the ticking of the redpiler direct backend
Where redpiler could schedule a tick inside of the tick method but the normal tick could not.
This might also explain some inconsistent behaviour between redpiler and the normal tick but I have not tested this yet.
Additionally it seems vanilla schedules this tick after updating the block-state while redpiler did this before updating.
I have tested the changes on Iris with the mandlebrot program on redpiler and it does not seem to break things, I haven't tested it much outside of that yet.
So I do still need to test the default backend.