-
-
Notifications
You must be signed in to change notification settings - Fork 94
Fix and simplify constant_coalesce pass #182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Stack trace 2025-02-05T18:53:55.869953Z ERROR mchprs_core::server: plot panicked at crates/core/src/plot/mod.rs:695:9: |
864ffc0 to
300a927
Compare
Currently the constant coalesce pass is broken, it crashes the plot both on chungus2 and on mpu8.
This pull request fixes this issue and also simplifies the constant coalesce pass by only having 1 constant node instead of 1 for each signal strength