Fix axiom schematics crashing the plot #208
Conversation
… property for sponge version 2
|
At some point we should also handle cases where those fields don't exist at all. The Sponge Schematic Specification actually specifies |
StackDoubleFlow
left a comment
StackDoubleFlow
left a comment
There was a problem hiding this comment.
Thanks for fixing this
| -nbt_as!(metadata["WEOffsetY"], Value::Int), | ||
| -nbt_as!(metadata["WEOffsetZ"], Value::Int), | ||
| ) | ||
| // Axiom stores the offset like version 3 but specifies version 2 |
There was a problem hiding this comment.
Actually, Axiom is correct to specificy Offset this way according to the version 2 spec. WorldEdit actually deviates from the spec here, and we were using WorldEdit as the source of truth before. Could you change the comment to not mention Axiom here? I don't want to throw them under the bus for something that isn't their problem.
| -nbt_as!(metadata["WEOffsetY"], Value::Int), | ||
| -nbt_as!(metadata["WEOffsetZ"], Value::Int), | ||
| ) | ||
| } |
There was a problem hiding this comment.
While you're here, could you use if let to check for "Metadata" as well, and then add an else case that just returns (0, 0, 0)
2 participants
For some reason Axiom uses the version 3 format for the offset but specifies version 2, thus trying to load in a schematic generated by the Axiom mod would crash the plot.
This fixes that by also checking for the Offset property for sponge version 2.