Remove noteblock pitch LUT #215
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problems with the current implementation using the LUT:
noteis out of range. I don't think panicking for an invalidnoteis appropriate.Some alternatives I explored: https://godbolt.org/z/8Txffr7d5
I decided to avoid all LUT-based implementations for this case because they either have a conditional branch or require the use of
unsafe. Also,f32::exp2(x)compiles down to a singlecvtsi2ssinstruction on x86_64, so why not compute the pitch directly?Computing the pitch is branchless and compute-bound instead of memory-bound. The CPU can probably find a way to slot the computation into its pipeline for free.