-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Update Bitnami to Bitnamilegacy for valkey package. #2044
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: staging
Are you sure you want to change the base?
Conversation
Due to Bitnami Valkey packages becoming hardened, only the :latest tag is available within the bitnami public catalogue. Without this change, the following error occurs: "Error response from daemon: failed to resolve reference "docker.io/bitnami/valkey:8.0": docker.io/bitnami/valkey:8.0: not found" Source: https://hub.docker.com/r/bitnami/valkey#%EF%B8%8F-important-notice-upcoming-changes-to-the-bitnami-catalog ------------------ Starting August 28th, over two weeks, all existing container images, including older or versioned tags (e.g., 2.50.0, 10.6), will be migrated from the public catalog (docker.io/bitnami) to the “Bitnami Legacy” repository (docker.io/bitnamilegacy), where they will no longer receive updates. -----------------
Updated docker-compose.prod.yaml to bitnamilegacy
Updated bitnami to bitnamilegacy
|
Warning Rate limit exceeded@CamosITSolutions has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 18 minutes and 37 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (2)
WalkthroughDocker Compose files updated to change the Valkey service image reference from Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
docker-compose.db.yaml(1 hunks)docker-compose.prod.yaml(1 hunks)
🔇 Additional comments (1)
docker-compose.prod.yaml (1)
71-71: Consistent with db.yaml updates; same migration concern applies to production.The production compose file correctly mirrors the bitnamilegacy migration from docker-compose.db.yaml. Healthcheck configuration (lines 77–81) is robust and well-tuned.
However, the same breaking-change risk noted for the dev environment applies here: production
valkey-datavolumes may become inaccessible or experience data loss after this upgrade.Please ensure that production deployment documentation or runbooks include guidance for users upgrading existing Valkey instances with persistent data.
Also applies to: 76-76
|
@coderabbitai generate docstrings |
✅ Actions performedInitiated docstring generation; will generate only if new commits exist. |
|
Caution Docstrings generation - FAILED No docstrings were generated. |
|
@coderabbitai help |
ChatThere are 3 ways to chat with CodeRabbit:
CodeRabbit commands
Other keywords and placeholders
CodeRabbit configuration file (
|
|
@coderabbitai run pre-merge checks |
✅ Actions performedRunning Pre-merge checks. Results will be posted in the summary comment once complete. |
|
@coderabbitai full review |
✅ Actions performedFull review triggered. |
Description
Due to Bitnami changes in their repository, only the :latest tag is available within the bitnami public catalogue, with this project using on version tag 8.0.
Without this change, the following error occurs when running pnpm docker:db:up: "Error response from daemon: failed to resolve reference "docker.io/bitnami/valkey:8.0": docker.io/bitnami/valkey:8.0: not found"
Source: https://hub.docker.com/r/bitnami/valkey#%EF%B8%8F-important-notice-upcoming-changes-to-the-bitnami-catalog --"
Starting August 28th, over two weeks, all existing container images, including older or versioned tags (e.g., 2.50.0, 10.6), will be migrated from the public catalog (docker.io/bitnami) to the “Bitnami Legacy” repository (docker.io/bitnamilegacy), where they will no longer receive updates.
"
Type of Change
Please delete options that are not relevant.
Areas Affected
Please check all that apply:
Testing Done
Describe the tests you've done:
This was changed in my local system, and after running 'pnpm docker:db:up' the errors dissapeared. This is a simple fix where the repository previously referenced (bitnami) no longer contains tagged versions.
Checklist
Additional Notes
Add any other context about the pull request here.
Screenshots/Recordings
Add screenshots or recordings here if applicable.
By submitting this pull request, I confirm that my contribution is made under the terms of the project's license.
Summary by CodeRabbit