Conversation
Keboo
reviewed
Oct 20, 2024
Co-authored-by: Kevin B <Keboo@users.noreply.github.com>
Keboo
approved these changes
Oct 24, 2024
JLdgu
pushed a commit
to JLdgu/MaterialDesignInXamlToolkit
that referenced
this pull request
Nov 8, 2024
…gnInXAML#3701) * Add AP to use for padding brush * Apply AP in SmartHint style * Forward AP and remove no longer needed trigger in TextBox style * Apply AP fix in AutoSuggestBox style * Apply AP fix in PasswordBox style * Apply AP fix in ComboBox style * Apply AP fix in DatePicker style * Apply AP fix in TimePicker style * Add showcasing of AP to demo apps * Adjust UI tests * Update src/MaterialDesignThemes.Wpf/HintAssist.cs Co-authored-by: Kevin B <Keboo@users.noreply.github.com> --------- Co-authored-by: Kevin B <Keboo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3700
Fixes #3262
If applying a custom background, the
MaterialDesignOutlinedTextBoxstyle by default uses the MDIX window background brushes for the "padding" on the hint (used to "erase" some of the outline border).This PR introduces an opt-in AP which allows consumers to override this to match their custom background.
In principle, a
PriorityBindingshould suffice for this in theSmartHintstyle, but yet again I was unable to make it work 😞 Thus I went for the converter approach I have ended up with before. Apparently I am not great friends with thePriorityBinding.For a more detailed explanation of the issue, see my comment here: #3262 (comment)
Before
HintAssist.Backgroundleft at default value (Transparent):HintAssist.Backgroundset to match background:After
HintAssist.Backgroundnot needed unless you want a custom background on the hint (floating and non-floating)