Fix AutomationProperties.Name binding errors for HintAssist.Hint#3946
Merged
Fix AutomationProperties.Name binding errors for HintAssist.Hint#3946
Conversation
Copilot
AI
changed the title
[WIP] Fix binding errors on AutomationProperties.Name in NumericUpDown
Oct 10, 2025
Keboo
reviewed
Oct 11, 2025
|
|
||
| namespace MaterialDesignThemes.Wpf.Converters; | ||
|
|
||
| public class ObjectToStringConverter : IValueConverter |
Member
There was a problem hiding this comment.
@copilot rename this to AutomationPropertiesNameConverter and move to the internal namespace
Contributor
Author
There was a problem hiding this comment.
Done. Renamed to AutomationPropertiesNameConverter and moved to the Internal namespace in commit 9619ddc.
Keboo
approved these changes
Oct 11, 2025
…ndings Co-authored-by: Keboo <952248+Keboo@users.noreply.github.com>
Co-authored-by: Keboo <952248+Keboo@users.noreply.github.com>
…nd move to Internal namespace Co-authored-by: Keboo <952248+Keboo@users.noreply.github.com>
Registers the 'convertersInternal' XML namespace in the DatePicker, NumericUpDown, and TimePicker theme dictionaries.
9e6071d to
8aeb89c
Compare
Keboo
approved these changes
Oct 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
AutomationProperties.Name binding errors were occurring in MaterialDesign controls (NumericUpDown, TextBox, ComboBox, etc.) when
HintAssist.Hintcontained non-string values. SinceHintAssist.Hintis of typeobject, binding it directly toAutomationProperties.Name(which expects astring) caused WPF binding errors in the output window.Solution
Created a new
AutomationPropertiesNameConverterin the Internal namespace that safely converts any value to a string for use with AutomationProperties.Name bindings:The converter was applied to all AutomationProperties.Name bindings that reference HintAssist.Hint across the theme files.
Changes
New Files
Modified Files
Applied the converter to 8 AutomationProperties.Name bindings in 7 XAML theme files:
Example Change
Before:
After:
Impact
Fixes #3941
Original prompt
Fixes #3945
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.