docs: fix reasoning_content field name and add Video to the modality row - #17
Open
Mr-Neutr0n wants to merge 1 commit into
Open
Conversation
Two inconsistencies inside the README, both checkable against the document
itself.
1. The usage example reads the wrong field.
Section 6 states the model "will return `reasoning_content`", and the
example message uses `reasoning_content` as the key. The print statement
then reads `.reasoning`:
print(f"response: {response.choices[0].message.reasoning}")
`reasoning_content` appears three times in that section (lines 617, 619,
632); `.reasoning` appears once, at line 649. Copy-pasting the example
prints None rather than the preserved thinking it is meant to demonstrate,
which is the whole point of the snippet.
2. The Model Summary table omits video.
The table lists Modality as "Text, Image", but the Key Features above it say
Kimi K3 "understands text, images, and video within the same model", and the
evaluation table reports Video-MME (w. sub) 90.0. A reader comparing the spec
table against the benchmarks gets contradictory answers about whether video
is supported.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two inconsistencies inside the README. Both are checkable against the document itself — no external knowledge needed.
1. The usage example reads the wrong field
Section 6 states the model "will return
reasoning_content", and the example message usesreasoning_contentas its key. The print statement then reads.reasoning:Counting occurrences in that section:
reasoning_contentappears at lines 617, 619 and 632;.reasoningappears once, at line 649. Copy-pasting the snippet printsNoneinstead of the preserved thinking it exists to demonstrate — which is the entire point of the example.2. The Model Summary table omits video
The table lists:
But the Key Features immediately above say Kimi K3 "understands text, images, and video within the same model", and the evaluation table reports:
So the spec table and the benchmark table give a reader contradictory answers about whether video is supported. Given the model is benchmarked on video and the feature list claims it, the table row looks like the thing that's out of date.
Diff is 2 lines. Happy to split into two PRs if you'd prefer them reviewed separately, and equally happy to close this if the modality row is deliberate and video is served by something other than the base weights.
Thanks for shipping the weights openly.