Fix PyQtGraph shape mismatch exception by passing levels synchronously#1477
Open
wong-ziyi wants to merge 1 commit into
Open
Fix PyQtGraph shape mismatch exception by passing levels synchronously#1477wong-ziyi wants to merge 1 commit into
wong-ziyi wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a user switches color views (e.g. from
rgbtogray) while rendering a 3D image, the dimensionality of the array sent topyqtgraphImageItemcan change. Ingui.py'supdate_plotfunction,self.img.setImageis called without thelevelskeyword argument, and thenself.img.setLevels(levels)is called sequentially.However,
pyqtgraphasynchronously processessetImageby invokingmakeARGBwith the cachedself.levelsfrom the previous image. If the new image has a different shape butpyqtgraphtries to unpack it using the older multi-channel levels buffer, it triggers internal exceptions such asValueError: too many values to unpack (expected 2)orException: levels must have shape (data.shape[-1], 2), causing the GUI rendering to abort or crash entirely.Solution
This PR modifies
update_plotincellpose/gui/gui.pyto synchronously supply thelevelsarguments directly into thesetImagefunction parameters, which prevents asynchronous rendering mismatches. This matches best-practice guidelines forpyqtgraph.