Fix Python 3.8 syntax error by removing 3.10 specific union type hint#1478
Open
wong-ziyi wants to merge 2 commits into
Open
Fix Python 3.8 syntax error by removing 3.10 specific union type hint#1478wong-ziyi wants to merge 2 commits into
wong-ziyi wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The recent updates to
gui.pyintroduced a Python 3.10+ specific type hinting syntax (str | int) on thecolorproperty setter:This breaks compatibility for users running Python 3.8 or 3.9, resulting in a
TypeError: unsupported operand type(s) for |: 'type' and 'type'upon starting the GUI.Solution
This PR simply removes the type hint (or could use
typing.Union[str, int]) to restore compatibility with older supported Python versions.