Move driver and nvrtc cython and internal layers to new generator#1972
Open
mdboom wants to merge 14 commits intoNVIDIA:mainfrom
Open
Move driver and nvrtc cython and internal layers to new generator#1972mdboom wants to merge 14 commits intoNVIDIA:mainfrom
mdboom wants to merge 14 commits intoNVIDIA:mainfrom
Conversation
Contributor
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
github-actions
Bot
added
the
cuda.bindings
Contributor
Author
|
/ok to test |
Contributor
Author
|
/ok to test |
Contributor
Author
|
/ok to test |
Contributor
Author
|
/ok to test |
1 similar comment
Contributor
Author
|
/ok to test |
github-actions
Bot
added
CI/CD
Contributor
Author
|
/ok to test |
Contributor
Author
|
/ok to test |
|
Contributor
Author
|
/ok to test |
Contributor
Author
|
/ok to test |
1 similar comment
Contributor
Author
|
/ok to test |
Contributor
Author
|
/ok to test |
Contributor
Author
|
/ok to test |
Contributor
Author
|
/ok to test |
Contributor
Author
|
/ok to test |
Contributor
Author
|
/ok to test |
leofang
reviewed
Apr 30, 2026
| from libc.stdint cimport uintptr_t | ||
| from cpython cimport PyUnicode_AsWideCharString, PyMem_Free | ||
|
|
||
| # You must 'from .utils import NotSupportedError' before using this template |
Member
There was a problem hiding this comment.
Note to self: check if this is from cybind template
| cdef int err, driver_ver = 0 | ||
|
|
||
| # Load driver to check version | ||
| handle = dlopen('libcuda.so.1', RTLD_NOW | RTLD_GLOBAL) |
Member
There was a problem hiding this comment.
Q: why don't we use pathfinder here?
| raise RuntimeError("Failed to get __cuGetProcAddress_v2") | ||
| _F_cuGetProcAddress_v2 = <__cuGetProcAddress_v2_T>__cuGetProcAddress_v2 | ||
|
|
||
| if os.getenv('CUDA_PYTHON_CUDA_PER_THREAD_DEFAULT_STREAM', default=0): |
Member
There was a problem hiding this comment.
Wouldn't this evaluate to True for export CUDA_PYTHON_CUDA_PER_THREAD_DEFAULT_STREAM=0?
>>> if '0': print(123)
...
123
Comment on lines
+591
to
+596
| # Get latest __cuGetProcAddress_v2 | ||
| global __cuGetProcAddress_v2 | ||
| __cuGetProcAddress_v2 = dlsym(handle, 'cuGetProcAddress_v2') | ||
| if __cuGetProcAddress_v2 == NULL: | ||
| raise RuntimeError("Failed to get __cuGetProcAddress_v2") | ||
| _F_cuGetProcAddress_v2 = <__cuGetProcAddress_v2_T>__cuGetProcAddress_v2 |
Member
There was a problem hiding this comment.
IIRC the old code has a path where we do dlsym to get unversioned symbols, is it no longer relevant?
| cdef int err, driver_ver = 0 | ||
|
|
||
| # Load driver to check version | ||
| handle = LoadLibraryExW("nvcuda.dll", NULL, LOAD_LIBRARY_SEARCH_SYSTEM32) |
leofang
added
P0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a continuation of the work in #1900. Now adds
driverto the mix and bothnvrtcanddriverare generated from the "real" new generator.