Rename GraphDef -> GraphDefinition and Condition -> GraphCondition#1984
Merged
Andy-Jost merged 1 commit intoNVIDIA:mainfrom Apr 28, 2026
Merged
Conversation
Spell out abbreviations for consistency with the rest of cuda.core (NVIDIA#1950) and add the Graph* prefix to Condition for consistency with GraphBuilder / GraphDefinition / GraphNode (NVIDIA#1945). Source file _graph_def.{pyx,pxd} and test files test_graphdef*.py renamed to match. 0.7.0 release notes converted to literal inline-code form for the old GraphDef name so :class: cross-references resolve cleanly in 1.0.0+ doc builds without rewriting historical claims. Made-with: Cursor
This comment has been minimized.
This comment has been minimized.
rparolin
approved these changes
Apr 28, 2026
This comment has been minimized.
This comment has been minimized.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Spell out abbreviations and apply the
Graph*prefix convention to twopublic classes in
cuda.core.graph, in preparation for the v1.0.0 API.GraphDef->GraphDefinition(cuda.core: public API class naming audit (PEP 8 and consistency) #1950)Condition->GraphCondition(cuda.core: method/member/property naming audit #1945)Changes
Public API
GraphDeftoGraphDefinitionincuda.core.graph. Re-exported under the new name fromcuda.core.ConditiontoGraphConditionincuda.core.graph. Re-exported under the new name fromcuda.core.Internal
cuda/core/graph/_graph_def.{pyx,pxd}to_graph_definition.{pyx,pxd}(history preserved viagit mv).tests/graph/test_graphdef*.pytotest_graph_definition*.py(5 files).sample_graphdef->sample_graph_definition, etc.) for consistency.Docs
1.0.0-notes.rstcalling out both renames with issue refs.0.7.0-notes.rst: switched two:class:Sphinx cross-references to literal inline-code form so they don't break in 1.0.0+ doc builds (text still factually saysGraphDef; historical 0.7.0 snapshot at0.7.0/URL is unaffected).docs/source/api.rstand all docstring references.Test Coverage
cuda_core/tests/graph/suite passes locally (renamed test files exercised end-to-end)._FORTIFY_SOURCEnotes from the build environment.Related Work
GraphDefrename item in cuda.core: public API class naming audit (PEP 8 and consistency) #1950.Conditionrename item from the unified-conditional-API proposal in cuda.core: method/member/property naming audit #1945.if_cond->if_then,create_conditional_handle->create_condition,__int__onGraphCondition,KernelAttributesindexed-property design) will land in follow-up PRs.Made with Cursor