Skip to content

Rename GraphDef -> GraphDefinition and Condition -> GraphCondition#1984

Merged
Andy-Jost merged 1 commit intoNVIDIA:mainfrom
Andy-Jost:rename-graphdef-graphcondition
Apr 28, 2026
Merged

Rename GraphDef -> GraphDefinition and Condition -> GraphCondition#1984
Andy-Jost merged 1 commit intoNVIDIA:mainfrom
Andy-Jost:rename-graphdef-graphcondition

Conversation

@Andy-Jost
Copy link
Copy Markdown
Contributor

Summary

Spell out abbreviations and apply the Graph* prefix convention to two
public classes in cuda.core.graph, in preparation for the v1.0.0 API.

Changes

Public API

  • Renamed class GraphDef to GraphDefinition in cuda.core.graph. Re-exported under the new name from cuda.core.
  • Renamed class Condition to GraphCondition in cuda.core.graph. Re-exported under the new name from cuda.core.
  • No backward-compatibility aliases (pre-1.0).

Internal

  • Renamed source files cuda/core/graph/_graph_def.{pyx,pxd} to _graph_definition.{pyx,pxd} (history preserved via git mv).
  • Renamed test files tests/graph/test_graphdef*.py to test_graph_definition*.py (5 files).
  • Renamed internal test fixtures and helper symbols (sample_graphdef -> sample_graph_definition, etc.) for consistency.

Docs

  • Added a "Breaking changes" entry in 1.0.0-notes.rst calling out both renames with issue refs.
  • 0.7.0-notes.rst: switched two :class: Sphinx cross-references to literal inline-code form so they don't break in 1.0.0+ doc builds (text still factually says GraphDef; historical 0.7.0 snapshot at 0.7.0/ URL is unaffected).
  • Updated docs/source/api.rst and all docstring references.

Test Coverage

  • Full cuda_core/tests/graph/ suite passes locally (renamed test files exercised end-to-end).
  • Editable build clean, pre-commit clean.
  • No new warnings beyond pre-existing _FORTIFY_SOURCE notes from the build environment.

Related Work

Made with Cursor

Spell out abbreviations for consistency with the rest of cuda.core (NVIDIA#1950)
and add the Graph* prefix to Condition for consistency with GraphBuilder
/ GraphDefinition / GraphNode (NVIDIA#1945).

Source file _graph_def.{pyx,pxd} and test files test_graphdef*.py renamed
to match. 0.7.0 release notes converted to literal inline-code form for
the old GraphDef name so :class: cross-references resolve cleanly in
1.0.0+ doc builds without rewriting historical claims.

Made-with: Cursor
@Andy-Jost Andy-Jost added this to the cuda.core v1.0.0 milestone Apr 28, 2026
@Andy-Jost Andy-Jost added enhancement Any code-related improvements cuda.core Everything related to the cuda.core module breaking Breaking changes are introduced labels Apr 28, 2026
@Andy-Jost Andy-Jost self-assigned this Apr 28, 2026
@Andy-Jost Andy-Jost requested review from leofang and mdboom April 28, 2026 20:32
@github-actions

This comment has been minimized.

@Andy-Jost Andy-Jost merged commit 6d4e82d into NVIDIA:main Apr 28, 2026
104 checks passed
@github-actions

This comment has been minimized.

@github-actions
Copy link
Copy Markdown

Doc Preview CI
Preview removed because the pull request was closed or merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking Breaking changes are introduced cuda.core Everything related to the cuda.core module enhancement Any code-related improvements

2 participants