Skip to content

cuda.core: add C++17 standard flag and use -O2 optimization#2002

Merged
leofang merged 2 commits intoNVIDIA:mainfrom
leofang:core-build-flags
May 1, 2026
Merged

cuda.core: add C++17 standard flag and use -O2 optimization#2002
leofang merged 2 commits intoNVIDIA:mainfrom
leofang:core-build-flags

Conversation

@leofang
Copy link
Copy Markdown
Member

@leofang leofang commented May 1, 2026 •
edited
Loading

Summary

  • Pass -std=c++17 (Linux) / /std:c++17 (Windows) for all builds
  • Use -O2 instead of -O3 for non-debug Linux builds

Partially addresses #1882 (items 1 & 2).

Test plan

  • CI build passes on Linux
  • CI build passes on Windows
@leofang @claude
cuda.core: add C++17 standard flag and use -O2 optimization
f96f149 
Pass -std=c++17 (Linux) / /std:c++17 (Windows) for all builds,
and use -O2 instead of -O3 for non-debug Linux builds.

Partially addresses NVIDIA#1882.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@copy-pr-bot
Copy link
Copy Markdown
Contributor

copy-pr-bot Bot commented May 1, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.
@github-actions github-actions Bot added the cuda.core Everything related to the cuda.core module label May 1, 2026
@leofang leofang added P0 High priority - Must do! packaging Anything related to wheels or Conda packages labels May 1, 2026
@leofang leofang self-assigned this May 1, 2026
@leofang leofang added this to the cuda.core v1.0.0 milestone May 1, 2026
@leofang
Copy link
Copy Markdown
Member Author

leofang commented May 1, 2026

/ok to test f96f149
@leofang
Copy link
Copy Markdown
Member Author

leofang commented May 1, 2026

/ok to test 8c00dc6
@leofang leofang marked this pull request as ready for review May 1, 2026 02:02
@github-actions

This comment has been minimized.

Sign in to view
@leofang leofang merged commit aac5bf5 into NVIDIA:main May 1, 2026
96 checks passed
@leofang
Copy link
Copy Markdown
Member Author

leofang commented May 1, 2026

Thanks, Rob!
@leofang leofang deleted the core-build-flags branch May 1, 2026 03:15
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 1, 2026

Doc Preview CI
Preview removed because the pull request was closed or merged.
@leofang leofang mentioned this pull request May 1, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cuda.core Everything related to the cuda.core module P0 High priority - Must do! packaging Anything related to wheels or Conda packages

2 participants

@leofang @rparolin