feat(types): add requestCommonPayment typings - #19496
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review. Walkthrough新增 Changes通用支付 API
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This change adds compile-time TypeScript support for an already available WeChat payment API without changing runtime behavior, permissions, or deployment. No actionable merge-blocking risk remains after normal checks and review. Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1 files. ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Some tools did not complete. Review the errors below. 🔧 ESLint
ESLint install timed out. The project may have too many dependencies for the sandbox. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
这个 PR 做了什么? (简要描述所做更改)
Taro.requestCommonPayment补充 TypeScript 声明,关闭 添加微信基础接口wx.requestCommonPayment(Object object) #16605。mode、字符串化signData、必填签名参数,以及 success/fail 回调结果。void,与 Taro 当前的原生透传行为保持一致。Fixes #16605
这个 PR 是什么类型? (至少选择一个)
这个 PR 涉及以下平台:
验证
void返回值、回调结果,以及非法 mode、未序列化signData、缺少签名等负向用例。origin/main运行同一 fixture,确认修复前因 API 缺失失败、修复后通过。npm pack确认声明进入@tarojs/tarotarball;解包后的消费者类型检查通过。Summary by CodeRabbit