Open
Conversation
✅ Deploy Preview for ohif-dev canceled.
|
Comment on lines
+84
to
+85
| const moreTools = basicModeInstance.toolbarSections['MoreTools'].filter(item => item !== 'Angle'); | ||
| const measurementTools = ['Angle',...basicModeInstance.toolbarSections['MeasurementTools']]; |
There was a problem hiding this comment.
check that basicModeInstance.toolbarSections['MoreTools'] and basicModeInstance.toolbarSections['MeasurementTools'] are arrays before using .filter() and spread operator
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Greptile Summary
This PR implements three test tasks: swapping left/right panels in a new layout, moving the
Angletool fromMoreToolstoMeasurementToolssection, and displaying the OHIF version in the viewport overlay.Key changes:
testTaskInstancelayout withtracked.measurementson left andtracked.thumbnailListon right (swapped fromlongitudinalInstance)testTaskRouteat path 'test-task' and set it as the active route inmodeInstance.routesAnglefromMoreToolsand prepended it toMeasurementToolsprocess.env.VERSION_NUMBERIssues found:
TOOLBAR_SECTIONSfromToolbarServiceis imported but not usedtoolbarSections['MoreTools']andtoolbarSections['MeasurementTools']are arrays without validationConfidence Score: 4/5
modes/longitudinal/src/index.tsneeds attention for the unused importImportant Files Changed
Angletool fromMoreToolstoMeasurementTools, includes unused importLast reviewed commit: a67a1fa
(2/5) Greptile learns from your feedback when you react with thumbs up/down!