Skip to content

Spsoft test task#5833

Open
ViBobukh wants to merge 5 commits intoOHIF:masterfrom
ViBobukh:spsoft-test-task
Open

Spsoft test task#5833
ViBobukh wants to merge 5 commits intoOHIF:masterfrom
ViBobukh:spsoft-test-task

Conversation

@ViBobukh
Copy link

@ViBobukh ViBobukh commented Feb 23, 2026

Greptile Summary

This PR implements three test tasks: swapping left/right panels in a new layout, moving the Angle tool from MoreTools to MeasurementTools section, and displaying the OHIF version in the viewport overlay.

Key changes:

  • Created testTaskInstance layout with tracked.measurements on left and tracked.thumbnailList on right (swapped from longitudinalInstance)
  • Added testTaskRoute at path 'test-task' and set it as the active route in modeInstance.routes
  • Reorganized toolbar tools: removed Angle from MoreTools and prepended it to MeasurementTools
  • Added OHIF version display (with 'v' label) in top-right viewport overlay using process.env.VERSION_NUMBER

Issues found:

  • Unused import: TOOLBAR_SECTIONS from ToolbarService is imported but not used
  • The code assumes toolbarSections['MoreTools'] and toolbarSections['MeasurementTools'] are arrays without validation

Confidence Score: 4/5

  • This PR is safe to merge with minor cleanup needed
  • The implementation is straightforward and follows existing patterns. The main issues are an unused import and missing runtime checks, neither of which will cause failures since the underlying data structures appear well-defined in the base mode
  • modes/longitudinal/src/index.ts needs attention for the unused import

Important Files Changed

Filename Overview
extensions/cornerstone/src/customizations/viewportOverlayCustomization.tsx Added OHIF version display in top-right viewport overlay with environment variable check
modes/longitudinal/src/index.ts Created test-task route with swapped panels, moved Angle tool from MoreTools to MeasurementTools, includes unused import

Last reviewed commit: a67a1fa

(2/5) Greptile learns from your feedback when you react with thumbs up/down!

@netlify
Copy link

netlify bot commented Feb 23, 2026

Deploy Preview for ohif-dev canceled.

Name Link
🔨 Latest commit 5fa4cd2
🔍 Latest deploy log https://app.netlify.com/projects/ohif-dev/deploys/699c477357bf450008d6bfc2
Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 files reviewed, 2 comments

Edit Code Review Agent Settings | Greptile

Comment on lines +84 to +85
const moreTools = basicModeInstance.toolbarSections['MoreTools'].filter(item => item !== 'Angle');
const measurementTools = ['Angle',...basicModeInstance.toolbarSections['MeasurementTools']];
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check that basicModeInstance.toolbarSections['MoreTools'] and basicModeInstance.toolbarSections['MeasurementTools'] are arrays before using .filter() and spread operator

Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant