Skip to content

Conversation

@issy
Copy link
Contributor

@issy issy commented Jan 1, 2026

In #880 I added support for flagging an operation ID change as a breaking change. However, I didn't add any rendering support for the operation ID changes. This meant that it might be unclear in some cases why a schema change was being marked as a breaking change.

To fix this, I've added rendering support for this type of change. However, the renderers will currently render the operation ID change regardless of whether it's configured to be recognised as a breaking change or not. I personally think that's fine, but I could be persuaded otherwise. I've done my best to match the style of the other diffs in the report.

Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 4 files

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="core/src/main/java/org/openapitools/openapidiff/core/output/HtmlRender.java">

<violation number="1" location="core/src/main/java/org/openapitools/openapidiff/core/output/HtmlRender.java:574">
P2: Missing null handling for operation ID values. If `getLeft()` or `getRight()` returns null, the output will display &quot;null&quot; in the rendered HTML. Consider adding null checks consistent with other methods in this file.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant