Skip to content
This repository was archived by the owner on Apr 9, 2026. It is now read-only.

Install pyopenms in build-push-notebooks workflow - #501

Merged
poshul merged 3 commits into
masterfrom
poshul-patch-5
Feb 1, 2026
Merged

Install pyopenms in build-push-notebooks workflow#501
poshul merged 3 commits into
masterfrom
poshul-patch-5

Conversation

@poshul

@poshul poshul commented Jan 30, 2026

Copy link
Copy Markdown
Collaborator

Since we now use a separate script we need to actually call it.

Summary by CodeRabbit

  • Chores
    • CI workflows now run an additional Python setup script during dependency installation, adding installation of a Python component.
    • Impact: improved reproducibility of the build and more complete dependency setup in continuous integration.

✏️ Tip: You can customize this high-level summary in your review settings.

Added a command to install pyopenms in the workflow.
@poshul
poshul requested a review from jpfeuffer January 30, 2026 12:19
@coderabbitai

coderabbitai Bot commented Jan 30, 2026

Copy link
Copy Markdown
📝 Walkthrough

Walkthrough

Added a step to two GitHub Actions workflows to run python3 docs/install_pyopenms.py during the dependency installation phase, executing an additional setup script after upgrading pip and installing requirements.

Changes

Cohort / File(s) Summary
CI workflows
.github/workflows/build-push-notebooks.yaml, .github/workflows/test-pr-sphinx.yml
Both workflow files now run python3 docs/install_pyopenms.py as part of the dependency installation step (after pip/jupyter/requirements installation). Verify CI runner has required system deps and that the script exits appropriately.

Suggested reviewers

  • matteopilz

Poem

🐰 A small script hops into the CI tree,
Installing PyOpenMS so builds run with glee,
Pip prances forward, dependencies in tune,
Rabbits cheer softly beneath the CI moon.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title directly matches the main objective: it specifies installing pyopenms in the build-push-notebooks workflow, which aligns with the PR description and the changes made.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch poshul-patch-5

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Install PyOpenMS after installing dependencies in the workflow.
@poshul
poshul merged commit bc4a134 into master Feb 1, 2026
7 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

1 participant