fix(bootstrap): trim whitespace from media_type in verify-hosted-bootstrap.sh - #2765
Open
vaibhavsrv wants to merge 1 commit into
Open
fix(bootstrap): trim whitespace from media_type in verify-hosted-bootstrap.sh#2765vaibhavsrv wants to merge 1 commit into
vaibhavsrv wants to merge 1 commit into
Conversation
vaibhavsrv
force-pushed
the
fix/verify-hosted-bootstrap-media-type-trim
branch
from
August 30, 2026 08:11
1d0cbf2 to
e9d586f
Compare
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In
ods/scripts/verify-hosted-bootstrap.sh,media_typeis extracted usingprintf '%s' "${content_type%%;*}" | tr '[:upper:]' '[:lower:]'. If the HTTPContent-Typeheader contains trailing spaces before the semicolon (e.g.text/plain ; charset=utf-8), the parameter expansion leaves trailing whitespace ("text/plain "), causing thecase "$media_type" in text/plain)check to fail unexpectedly.Fix
Pipe
media_typethroughxargsinverify-hosted-bootstrap.shto trim surrounding whitespace before running header format checks.Verification
Ran
bash -n ods/scripts/verify-hosted-bootstrap.sh(passed cleanly).git diff --checkpassed cleanly.